8000 minor #24846 Fix some signatures in PHP-DSLs (nicolas-grekas) · symfony/symfony@88f228b · GitHub
[go: up one dir, main page]

Skip to content

Commit 88f228b

Browse files
minor #24846 Fix some signatures in PHP-DSLs (nicolas-grekas)
This PR was merged into the 3.4 branch. Discussion ---------- Fix some signatures in PHP-DSLs | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- af85431 Fix some signatures in PHP-DSLs
2 parents c4ae739 + af85431 commit 88f228b

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ContainerConfigurator extends AbstractConfigurator
3232
private $path;
3333
private $file;
3434

35-
public function __construct(ContainerBuilder $container, PhpFileLoader $loader, &$instanceof, $path, $file)
35+
public function __construct(ContainerBuilder $container, PhpFileLoader $loader, array &$instanceof, $path, $file)
3636
{
3737
$this->container = $container;
3838
$this->loader = $loader;
@@ -66,15 +66,15 @@ final public function import($resource, $type = null, $ignoreErrors = false)
6666
/**
6767
* @return ParametersConfigurator
6868
*/
69-
public function parameters()
69+
final public function parameters()
7070
{
7171
return new ParametersConfigurator($this->container);
7272
}
7373

7474
/**
7575
* @return ServicesConfigurator
7676
*/
77-
public function services()
77+
final public function services()
7878
{
7979
return new ServicesConfigurator($this->container, $this->loader, $this->instanceof);
8080
}

src/Symfony/Component/DependencyInjection/Loader/Configurator/ServicesConfigurator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function __construct(ContainerBuilder $container, PhpFileLoader $loader,
4646
*
4747
* @return DefaultsConfigurator
4848
*/
49-
public function defaults()
49+
final public function defaults()
5050
{
5151
return new DefaultsConfigurator($this, $this->defaults = new Definition());
5252
}

src/Symfony/Component/Routing/Loader/Configurator/Traits/RouteTrait.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ trait RouteTrait
2424
/**
2525
* Adds defaults.
2626
*
27-
* @param array $defaults
28-
*
2927
* @return $this
3028
*/
3129
final public function defaults(array $defaults)
@@ -38,8 +36,6 @@ final public function defaults(array $defaults)
3836
/**
3937
* Adds requirements.
4038
*
41-
* @param array $requirements
42-
*
4339
* @return $this
4440
*/
4541
final public function requirements(array $requirements)
@@ -52,8 +48,6 @@ final public function requirements(array $requirements)
5248
/**
5349
* Adds options.
5450
*
55-
* @param array $options
56-
*
5751
* @return $this
5852
*/
5953
final public function options(array $options)

0 commit comments

Comments
 (0)
0