minor #35106 Use spaces correctly to display options in DebugCommand (ruudk)

nicolas-grekas · nicolas-grekas · commit 8855082ffdc9 · 2019-12-26T09:30:00.000+01:00
This PR was submitted for the master branch but it was merged into the 4.3 branch instead. Discussion ---------- Use spaces correctly to display options in DebugCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Messenger ships with a DebugCommand. It doesn't properly place spaces for every option. ```diff - handled by Symfony\Component\Messenger\Tests\Fixtures\DummyCommandHandler (when option1=1, option2=2) + handled by Symfony\Component\Messenger\Tests\Fixtures\DummyCommandHandler (when option1=1, option2=2) ``` Commits ------- 1c92e9e Use spaces correctly to display options in DebugCommand
diff --git a/src/Symfony/Component/Messenger/Command/DebugCommand.php b/src/Symfony/Component/Messenger/Command/DebugCommand.php
@@ -108,9 +108,9 @@ private function formatConditions(array $options): string
 
         $optionsMapping = [];
         foreach ($options as $key => $value) {
-            $optionsMapping[] = ' '.$key.'='.$value;
+            $optionsMapping[] = $key.'='.$value;
         }
 
-        return ' (when'.implode(', ', $optionsMapping).')';
+        return ' (when '.implode(', ', $optionsMapping).')';
     }
 }
diff --git a/src/Symfony/Component/Messenger/Tests/Command/DebugCommandTest.php b/src/Symfony/Component/Messenger/Tests/Command/DebugCommandTest.php
@@ -40,7 +40,7 @@ public function testOutput()
     {
         $command = new DebugCommand([
             'command_bus' => [
-                DummyCommand::class => [[DummyCommandHandler::class, []]],
+                DummyCommand::class => [[DummyCommandHandler::class, ['option1' => '1', 'option2' => '2']]],
                 MultipleBusesMessage::class => [[MultipleBusesMessageHandler::class, []]],
             ],
             'query_bus' => [
@@ -62,12 +62,12 @@ public function testOutput()
 
  The following messages can be dispatched:
 
- --------------------------------------------------------------------------------------- 
-  Symfony\Component\Messenger\Tests\Fixtures\DummyCommand                                
-      handled by Symfony\Component\Messenger\Tests\Fixtures\DummyCommandHandler          
-  Symfony\Component\Messenger\Tests\Fixtures\MultipleBusesMessage                        
-      handled by Symfony\Component\Messenger\Tests\Fixtures\MultipleBusesMessageHandler  
- --------------------------------------------------------------------------------------- 
+ ----------------------------------------------------------------------------------------------------------- 
+  Symfony\Component\Messenger\Tests\Fixtures\DummyCommand                                                    
+      handled by Symfony\Component\Messenger\Tests\Fixtures\DummyCommandHandler (when option1=1, option2=2)  
+  Symfony\Component\Messenger\Tests\Fixtures\MultipleBusesMessage                                            
+      handled by Symfony\Component\Messenger\Tests\Fixtures\MultipleBusesMessageHandler                      
+ ----------------------------------------------------------------------------------------------------------- 
 
 query_bus
 ---------

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,9 @@ private function formatConditions(array $options): string`
`108`	`108`
`109`	`109`	`$optionsMapping = [];`
`110`	`110`	`foreach ($options as $key => $value) {`
`111`		`- $optionsMapping[] = ' '.$key.'='.$value;`
	`111`	`+ $optionsMapping[] = $key.'='.$value;`
`112`	`112`	`}`
`113`	`113`
`114`		`- return ' (when'.implode(', ', $optionsMapping).')';`
	`114`	`+ return ' (when '.implode(', ', $optionsMapping).')';`
`115`	`115`	`}`
`116`	`116`	`}`