[Process] In edge cases getcwd() can return false, then proc_open() should get null to use default value (the working dir of the current PHP process)

stloyd · stloyd · commit 880da01c49a9 · 2013-01-10T12:59:53.000+01:00
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -53,7 +53,7 @@ public function __construct($commandline, $cwd = null, array $env = null, $stdin
         }
 
         $this->commandline = $commandline;
-        $this->cwd = null === $cwd ? getcwd() : $cwd;
+        $this->cwd = $cwd;
         if (null !== $env) {
             $this->env = array();
             foreach ($env as $key => $value) {
@@ -359,6 +359,13 @@ public function setTimeout($timeout)
      */
     public function getWorkingDirectory()
     {
+        // This is for BC only
+        if (null === $this->cwd) {
+            // getcwd() will return false if any one of the parent directories does not have
+            // the readable or search mode set, even if the current directory does
+            return getcwd() ?: null;
+        }
+
         return $this->cwd;
     }
 
