minor #25402 Remove some unused variables and properties (tgalopin)

nicolas-grekas · nicolas-grekas · commit 8621bd25693a · 2017-12-08T16:26:26.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- Remove some unused variables and properties | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Analyzing symfony/symfony using https://insight.sensiolabs.com, I found several chunks of dead code. This PR removes them in the 3.4 branch. Commits ------- ec92d9b Remove some unused variables and properties
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
@@ -246,7 +246,7 @@ public function filterToServiceTypes($serviceId)
         }
 
         try {
-            $r = new \ReflectionClass($serviceId);
+            new \ReflectionClass($serviceId);
 
             return true;
         } catch (\ReflectionException $e) {
diff --git a/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php b/src/Symfony/Component/Cache/Adapter/TagAwareAdapter.php
@@ -32,7 +32,7 @@ class TagAwareAdapter implements TagAwareAdapterInterface, PruneableInterface, R
     private $setCacheItemTags;
     private $getTagsByKey;
     private $invalidateTags;
-    private $tagsPool;
+    private $tags;
 
     public function __construct(AdapterInterface $itemsPool, AdapterInterface $tagsPool = null)
     {
diff --git a/src/Symfony/Component/Lock/Store/MemcachedStore.php b/src/Symfony/Component/Lock/Store/MemcachedStore.php
@@ -24,12 +24,6 @@
  */
 class MemcachedStore implements StoreInterface
 {
-    private static $defaultClientOptions = array(
-        'persistent_id' => null,
-        'username' => null,
-        'password' => null,
-    );
-
     private $memcached;
     private $initialTtl;
     /** @var bool */
diff --git a/src/Symfony/Component/Yaml/Parser.php b/src/Symfony/Component/Yaml/Parser.php
@@ -362,8 +362,6 @@ private function doParse($value, $flags)
                             @trigger_error($this->getDeprecationMessage(sprintf('Duplicate key "%s" detected whilst parsing YAML. Silent handling of duplicate mapping keys in YAML is deprecated since version 3.2 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0.', $key)), E_USER_DEPRECATED);
                         }
                     } else {
-                        // remember the parsed line number here in case we need it to provide some contexts in error messages below
-                        $realCurrentLineNbKey = $this->getRealCurrentLineNb();
                         $value = $this->parseBlock($this->getRealCurrentLineNb() + 1, $this->getNextEmbedBlock(), $flags);
                         if ('<<' === $key) {
                             $this->refs[$refMatches['ref']] = $value;

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ public function filterToServiceTypes($serviceId)`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`try {`
`249`		`- $r = new \ReflectionClass($serviceId);`
	`249`	`+ new \ReflectionClass($serviceId);`
`250`	`250`
`251`	`251`	`return true;`
`252`	`252`	`} catch (\ReflectionException $e) {`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class TagAwareAdapter implements TagAwareAdapterInterface, PruneableInterface, R`
`32`	`32`	`private $setCacheItemTags;`
`33`	`33`	`private $getTagsByKey;`
`34`	`34`	`private $invalidateTags;`
`35`		`- private $tagsPool;`
	`35`	`+ private $tags;`
`36`	`36`
`37`	`37`	`public function __construct(AdapterInterface $itemsPool, AdapterInterface $tagsPool = null)`
`38`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -362,8 +362,6 @@ private function doParse($value, $flags)`
`362`	`362`	`@trigger_error($this->getDeprecationMessage(sprintf('Duplicate key "%s" detected whilst parsing YAML. Silent handling of duplicate mapping keys in YAML is deprecated since version 3.2 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0.', $key)), E_USER_DEPRECATED);`
`363`	`363`	`}`
`364`	`364`	`} else {`
`365`		`- // remember the parsed line number here in case we need it to provide some contexts in error messages below`
`366`		`- $realCurrentLineNbKey = $this->getRealCurrentLineNb();`
`367`	`365`	`$value = $this->parseBlock($this->getRealCurrentLineNb() + 1, $this->getNextEmbedBlock(), $flags);`
`368`	`366`	`if ('<<' === $key) {`
`369`	`367`	`$this->refs[$refMatches['ref']] = $value;`