[HttpKernel] Log/Collect exceptions at prio 0

ro0NL · fabpot · commit 85b832bcc9d8 · 2018-06-10T11:25:14.000+02:00
diff --git a/src/Symfony/Component/HttpKernel/CHANGELOG.md b/src/Symfony/Component/HttpKernel/CHANGELOG.md
@@ -5,7 +5,7 @@ CHANGELOG
 -----
 
  * added orphaned events support to `EventDataCollector`
- * `ExceptionListener` now logs and collects exceptions at priority `2048` (previously logged at `-128` and collected at `0`)
+ * `ExceptionListener` now logs exceptions at priority `0` (previously logged at `-128`)
  * Deprecated `service:action` syntax with a single colon to reference controllers. Use `service::method` instead.
  * Added the ability to profile individual argument value resolvers via the
    `Symfony\Component\HttpKernel\Controller\ArgumentResolver\TraceableValueResolver`
diff --git a/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php b/src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php
@@ -44,7 +44,6 @@ public function __construct($controller, LoggerInterface $logger = null, $debug
     public function logKernelException(GetResponseForExceptionEvent $event)
     {
         $exception = $event->getException();
-        $request = $event->getRequest();
 
         $this->logException($exception, sprintf('Uncaught PHP Exception %s: "%s" at %s line %s', get_class($exception), $exception->getMessage(), $exception->getFile(), $exception->getLine()));
     }
@@ -90,7 +89,7 @@ public static function getSubscribedEvents()
     {
         return array(
             KernelEvents::EXCEPTION => array(
-                array('logKernelException', 2048),
+                array('logKernelException', 0),
                 array('onKernelException', -128),
             ),
         );
diff --git a/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php b/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php
@@ -121,7 +121,7 @@ public static function getSubscribedEvents()
     {
         return array(
             KernelEvents::RESPONSE => array('onKernelResponse', -100),
-            KernelEvents::EXCEPTION => array('onKernelException', 2048),
+            KernelEvents::EXCEPTION => array('onKernelException', 0),
             KernelEvents::TERMINATE => array('onKernelTerminate', -1024),
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ public function __construct($controller, LoggerInterface $logger = null, $debug`
`44`	`44`	`public function logKernelException(GetResponseForExceptionEvent $event)`
`45`	`45`	`{`
`46`	`46`	`$exception = $event->getException();`
`47`		`- $request = $event->getRequest();`
`48`	`47`
`49`	`48`	`$this->logException($exception, sprintf('Uncaught PHP Exception %s: "%s" at %s line %s', get_class($exception), $exception->getMessage(), $exception->getFile(), $exception->getLine()));`
`50`	`49`	`}`
`@@ -90,7 +89,7 @@ public static function getSubscribedEvents()`
`90`	`89`	`{`
`91`	`90`	`return array(`
`92`	`91`	`KernelEvents::EXCEPTION => array(`
`93`		`- array('logKernelException', 2048),`
	`92`	`+ array('logKernelException', 0),`
`94`	`93`	`array('onKernelException', -128),`
`95`	`94`	`),`
`96`	`95`	`);`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public static function getSubscribedEvents()`
`121`	`121`	`{`
`122`	`122`	`return array(`
`123`	`123`	`KernelEvents::RESPONSE => array('onKernelResponse', -100),`
`124`		`- KernelEvents::EXCEPTION => array('onKernelException', 2048),`
	`124`	`+ KernelEvents::EXCEPTION => array('onKernelException', 0),`
`125`	`125`	`KernelEvents::TERMINATE => array('onKernelTerminate', -1024),`
`126`	`126`	`);`
`127`	`127`	`}`