minor #34675 [DI] Missing test on YamlFileLoader (maxhelias)

nicolas-grekas · nicolas-grekas · commit 84b5db3a4491 · 2019-11-28T12:10:43.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Missing test on YamlFileLoader | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? |no | Deprecations? |no | Tickets | - | License | MIT | Doc PR | - Missing test on YamlFileLoader Commits ------- b9d5237 [DI] Missing test on YamlFileLoader
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php
@@ -349,6 +349,9 @@ public function testParsesIteratorArgument()
         $lazyDefinition = $container->getDefinition('lazy_context');
 
         $this->assertEquals([new IteratorArgument(['k1' => new Reference('foo.baz'), 'k2' => new Reference('service_container')]), new IteratorArgument([])], $lazyDefinition->getArguments(), '->load() parses lazy arguments');
+
+        $message = 'The "deprecated_service" service is deprecated. You should stop using it, as it will soon be removed.';
+        $this->assertSame($message, $container->getDefinition('deprecated_service')->getDeprecationMessage('deprecated_service'));
     }
 
     public function testAutowire()
@@ -717,4 +720,17 @@ public function testOverriddenDefaultsBindings()
 
         $this->assertSame('overridden', $container->get('bar')->quz);
     }
+
+    /**
+     * @group legacy
+     * @expectedDeprecation The configuration key "factory" is unsupported for the service "foo" which is defined as an alias in %s.
+     * @expectedDeprecation The configuration key "parent" is unsupported for the service "foo" which is defined as an alias in %s.
+     */
+    public function testAliasDefinitionContainsUnsupportedElements()
+    {
+        $container = new ContainerBuilder();
+        $loader = new YamlFileLoader($container, new FileLocator(self::$fixturesPath.'/yaml'));
+        $loader->load('legacy_invalid_alias_definition.yml');
+        $this->assertTrue($container->has('foo'));
+    }
 }
