8000 [Notifier] Change return type · symfony/symfony@84937b9 · GitHub
[go: up one dir, main page]
Skip to content

Commit 84937b9

Browse files
OskarStarkOskarStark
committed
[Notifier] Change return type
1 parent c9c6a78 commit 84937b9

File tree

5 files changed

+13
-3
lines changed

5 files changed

+13
-3
lines changed

‎UPGRADE-5.3.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ HttpKernel
2323

2424
* Marked the class `Symfony\Component\HttpKernel\EventListener\DebugHandlersListener` as internal
2525

26+
Notifier
27+
-------
28+
29+
* Changed the return type of `Symfony\Component\Notifier\Transport\AbstractTransportFactory::getEndpoint()` from `?string` to `string`
30+
2631
PhpunitBridge
2732
-------------
2833

‎src/Symfony/Component/Notifier/Bridge/Infobip/InfobipTransport.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected function doSend(MessageInterface $message): SentMessage
8787
return new SentMessage($message, (string) $this);
8888
}
8989

90-
protected function getEndpoint(): ?string
90+
protected function getEndpoint(): string
9191
{
9292
return $this->host.($this->port ? ':'.$this->port : '');
9393
}

‎src/Symfony/Component/Notifier/Bridge/Mattermost/MattermostTransport.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ protected function doSend(MessageInterface $message): SentMessage
8787
return $sentMessage;
8888
}
8989

90-
protected function getEndpoint(): ?string
90+
protected function getEndpoint(): string
9191
{
9292
return rtrim($this->host.($this->port ? ':'.$this->port : '').($this->path ?? ''), '/');
9393
}

‎src/Symfony/Component/Notifier/CHANGELOG.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
5.3.0
5+
-----
6+
7+
* [BC BREAK] Changed the return type of `AbstractTransportFactory::getEndpoint()` from `?string` to `string`
8+
49
5.2.0
510
-----
611

‎src/Symfony/Component/Notifier/Transport/AbstractTransport.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function send(MessageInterface $message): SentMessage
8181

8282
abstract protected function doSend(MessageInterface $message): SentMessage;
8383

84-
protected function getEndpoint(): ?string
84+
protected function getEndpoint(): string
8585
{
8686
return ($this->host ?: $this->getDefaultHost()).($this->port ? ':'.$this->port : '');
8787
}

0 commit comments

Comments
 (0)
0