bug #41782 [FrameworkBundle] fix removing "action" from route names (nicolas-grekas)

Tobion · Tobion · commit 83825c56c083 · 2021-07-07T17:04:21.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] fix removing "action" from route names | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40024 | License | MIT | Doc PR | - Commits ------- 7f4a84f [FrameworkBundle] fix removing "action" from route names
diff --git a/src/Symfony/Bundle/FrameworkBundle/Routing/AnnotatedRouteControllerLoader.php b/src/Symfony/Bundle/FrameworkBundle/Routing/AnnotatedRouteControllerLoader.php
@@ -41,14 +41,12 @@ protected function configureRoute(Route $route, \ReflectionClass $class, \Reflec
      */
     protected function getDefaultRouteName(\ReflectionClass $class, \ReflectionMethod $method)
     {
-        return preg_replace([
-            '/(bundle|controller)_/',
-            '/action(_\d+)?$/',
-            '/__/',
-        ], [
-            '_',
-            '\\1',
-            '_',
-        ], parent::getDefaultRouteName($class, $method));
+        $name = preg_replace('/(bundle|controller)_/', '_', parent::getDefaultRouteName($class, $method));
+
+        if (str_ends_with($method->name, 'Action') || str_ends_with($method->name, '_action')) {
+            $name = preg_replace('/action(_\d+)?$/', '\\1', $name);
+        }
+
+        return str_replace('__', '_', $name);
     }
 }
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/AnnotatedControllerTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/AnnotatedControllerTest.php
@@ -23,6 +23,10 @@ public function testAnnotatedController($path, $expectedValue)
 
         $this->assertSame(200, $client->getResponse()->getStatusCode());
         $this->assertSame($expectedValue, $client->getResponse()->getContent());
+
+        $router = self::$container->get('router');
+
+        $this->assertSame('/annotated/create-transaction', $router->generate('symfony_framework_tests_functional_test_annotated_createtransaction'));
     }
 
     public function getRoutes()
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Controller/AnnotatedController.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/Bundle/TestBundle/Controller/AnnotatedController.php
@@ -48,4 +48,12 @@ public function argumentWithoutDefaultWithRouteParamAndDefaultAction($value)
     {
         return new Response($value);
     }
+
+    /**
+     * @Route("/create-transaction")
+     */
+    public function createTransaction()
+    {
+        return new Response();
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,10 @@ public function testAnnotatedController($path, $expectedValue)`
`23`	`23`
`24`	`24`	`$this->assertSame(200, $client->getResponse()->getStatusCode());`
`25`	`25`	`$this->assertSame($expectedValue, $client->getResponse()->getContent());`
	`26`	`+`
	`27`	`+ $router = self::$container->get('router');`
	`28`	`+`
	`29`	`+ $this->assertSame('/annotated/create-transaction', $router->generate('symfony_framework_tests_functional_test_annotated_createtransaction'));`
`26`	`30`	`}`
`27`	`31`
`28`	`32`	`public function getRoutes()`
Original file line number	Diff line number	Diff line change
`@@ -48,4 +48,12 @@ public function argumentWithoutDefaultWithRouteParamAndDefaultAction($value)`
`48`	`48`	`{`
`49`	`49`	`return new Response($value);`
`50`	`50`	`}`
	`51`	`+`
	`52`	`+ /**`
	`53`	`+ * @Route("/create-transaction")`
	`54`	`+ */`
	`55`	`+ public function createTransaction()`
	`56`	`+ {`
	`57`	`+ return new Response();`
	`58`	`+ }`
`51`	`59`	`}`