8000 minor #20052 @expectedException expects FQCN (ro0NL) · symfony/symfony@8330e9e · GitHub
[go: up one dir, main page]
Skip to content

Commit 8330e9e

Browse files
fabpotfabpot
committed
minor #20052 @ExpectedException expects FQCN (ro0NL)
This PR was merged into the 3.1 branch. Discussion ---------- @ExpectedException expects FQCN | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | comma-separated list of tickets fixed by the PR, if any | License | MIT | Doc PR | reference to the documentation PR, if any Sorry.. almost there :) fixes 1 more false positive in `ObjectNormalizerTest`. PHP-CS-Fixer/PHP-CS-Fixer#2200 is almost ready :) Commits ------- 7574a92 fixed expected exception annotations
2 parents 90f6b30 + 7574a92 commit 8330e9e

File tree

7 files changed

+10
-11
lines changed

7 files changed

+10
-11
lines changed

‎src/Symfony/Component/Cache/Tests/Adapter/ProxyAdapterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function createCachePool($defaultLifetime = 0)
3232
}
3333

3434
/**
35-
* @expectedException Exception
35+
* @expectedException \Exception
3636
* @expectedExceptionMessage OK bar
3737
*/
3838
public function testProxyfiedItem()

‎src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function testCreateConnection()
4646

4747
/**
4848
* @dataProvider provideFailedCreateConnection
49-
* @expectedException Symfony\Component\Cache\Exception\InvalidArgumentException
49+
* @expectedException \Symfony\Component\Cache\Exception\InvalidArgumentException
5050
* @expectedExceptionMessage Redis connection failed
5151
*/
5252
public function testFailedCreateConnection($dsn)
@@ -65,7 +65,7 @@ public function provideFailedCreateConnection()
6565

6666
/**
6767
* @dataProvider provideInvalidCreateConnection
68-
* @expectedException Symfony\Component\Cache\Exception\InvalidArgumentException
68+
* @expectedException \Symfony\Component\Cache\Exception\InvalidArgumentException
6969
* @expectedExceptionMessage Invalid Redis DSN
7070
*/
7171
public function testInvalidCreateConnection($dsn)

‎src/Symfony/Component/Cache/Tests/CacheItemTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public function testValidKey()
2222

2323
/**
2424
* @dataProvider provideInvalidKey
25-
* @expectedException Symfony\Component\Cache\Exception\InvalidArgumentException
25+
* @expectedException \Symfony\Component\Cache\Exception\InvalidArgumentException
2626
* @expectedExceptionMessage Cache key
2727
*/
2828
public function testInvalidKey($key)

‎src/Symfony/Component/Config/Tests/Definition/Builder/BooleanNodeDefinitionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class BooleanNodeDefinitionTest extends \PHPUnit_Framework_TestCase
1717
{
1818
/**
19-
* @expectedException Symfony\Component\Config\Definition\Exception\InvalidDefinitionException
19+
* @expectedException \Symfony\Component\Config\Definition\Exception\InvalidDefinitionException
2020
* @expectedExceptionMessage ->cannotBeEmpty() is not applicable to BooleanNodeDefinition.
2121
*/
2222
public function testCannotBeEmptyThrowsAnException()

‎src/Symfony/Component/Config/Tests/Definition/Builder/NumericNodeDefinitionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public function testFloatValidMinMaxAssertion()
9292
}
9393

9494
/**
95-
* @expectedException Symfony\Component\Config\Definition\Exception\InvalidDefinitionException
95+
* @expectedException \Symfony\Component\Config\Definition\Exception\InvalidDefinitionException
9696
* @expectedExceptionMessage ->cannotBeEmpty() is not applicable to NumericNodeDefinition.
9797
*/
9898
public function testCannotBeEmptyThrowsAnException()

‎src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
use Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor;
1616
use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
1717
use Symfony\Component\PropertyInfo\PropertyInfoExtractor;
18-
use Symfony\Component\Serializer\Exception\UnexpectedValueException;
1918
use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter;
2019
use Symfony\Component\Serializer\Normalizer\ArrayDenormalizer;
2120
use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
@@ -546,7 +545,7 @@ public function testDenomalizeRecursive()
546545
}
547546

548547
/**
549-
* @expectedException UnexpectedValueException
548+
* @expectedException \Symfony\Component\Serializer\Exception\UnexpectedValueException
550549
* @expectedExceptionMessage The type of the "date" attribute for class "Symfony\Component\Serializer\Tests\Normalizer\ObjectOuter" must be one of "DateTimeInterface" ("string" given).
551550
*/
552551
public function testRejectInvalidType()
@@ -558,7 +557,7 @@ public function testRejectInvalidType()
558557
}
559558

560559
/**
561-
* @expectedException UnexpectedValueException
560+
* @expectedException \Symfony\Component\Serializer\Exception\UnexpectedValueException
562561
* @expectedExceptionMessage The type of the key "a" must be "int" ("string" given).
563562
*/
564563
public function testRejectInvalidKey()

‎src/Symfony/Component/Yaml/Tests/InlineTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ public function testParseUnquotedAsteriskFollowedByAComment()
225225

226226
/**
227227
* @dataProvider getReservedIndicators
228-
* @expectedException Symfony\Component\Yaml\Exception\ParseException
228+
* @expectedException \Symfony\Component\Yaml\Exception\ParseException
229229
* @expectedExceptionMessage cannot start a plain scalar; you need to quote the scalar.
230230
*/
231231
public function testParseUnquotedScalarStartingWithReservedIndicator($indicator)
@@ -240,7 +240,7 @@ public function getReservedIndicators()
240240

241241
/**
242242
* @dataProvider getScalarIndicators
243-
* @expectedException Symfony\Component\Yaml\Exception\ParseException
243+
* @expectedException \Symfony\Component\Yaml\Exception\ParseException
244244
* @expectedExceptionMessage cannot start a plain scalar; you need to quote the scalar.
245245
*/
246246
public function testParseUnquotedScalarStartingWithScalarIndicator($indicator)

0 commit comments

Comments
 (0)
0