minor #31132 [VarDumper][Ldap] relax some locally failing tests (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 82f003eaf35f · 2019-04-17T16:54:02.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper][Ldap] relax some locally failing tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 88b2765 [VarDumper][Ldap] relax some locally failing tests
diff --git a/src/Symfony/Component/Ldap/Tests/LdapTestCase.php b/src/Symfony/Component/Ldap/Tests/LdapTestCase.php
@@ -8,6 +8,14 @@ class LdapTestCase extends TestCase
 {
     protected function getLdapConfig()
     {
+        $h = @ldap_connect(getenv('LDAP_HOST'), getenv('LDAP_PORT'));
+
+        if (!$h || !@ldap_bind($h)) {
+            $this->markTestSkipped('No server is listening on LDAP_HOST:LDAP_PORT');
+        }
+
+        ldap_close($h);
+
         return [
             'host' => getenv('LDAP_HOST'),
             'port' => getenv('LDAP_PORT'),
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php
@@ -37,7 +37,7 @@ public function testReflectionCaster()
 %A]
   constants: array:3 [
     "IS_IMPLICIT_ABSTRACT" => 16
-    "IS_EXPLICIT_ABSTRACT" => 32
+    "IS_EXPLICIT_ABSTRACT" => %d
     "IS_FINAL" => %d
   ]
   properties: array:%d [

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function testReflectionCaster()`
`37`	`37`	`%A]`
`38`	`38`	`constants: array:3 [`
`39`	`39`	`"IS_IMPLICIT_ABSTRACT" => 16`
`40`		`- "IS_EXPLICIT_ABSTRACT" => 32`
	`40`	`+ "IS_EXPLICIT_ABSTRACT" => %d`
`41`	`41`	`"IS_FINAL" => %d`
`42`	`42`	`]`
`43`	`43`	`properties: array:%d [`