minor #47937 [FrameworkBundle] remove DateTime from core Bundles (WebMamba)

fabpot · fabpot · commit 823f33244477 · 2022-10-20T20:31:21.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [FrameworkBundle] remove DateTime from core Bundles | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #47580 | License | MIT | Doc PR | symfony/symfony-docs Remove DateTime from all core bundles. Find also some DateTime in the SecurityBundle, but expose to BC breaks so will be treated in another PR. Commits ------- 03ea8ff remove DateTime from FrameworkBundle
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php
@@ -114,15 +114,15 @@ private static function formatFileSize(string $path): string
 
     private static function isExpired(string $date): bool
     {
-        $date = \DateTime::createFromFormat('d/m/Y', '01/'.$date);
+        $date = \DateTimeImmutable::createFromFormat('d/m/Y', '01/'.$date);
 
-        return false !== $date && new \DateTime() > $date->modify('last day of this month 23:59:59');
+        return false !== $date && new \DateTimeImmutable() > $date->modify('last day of this month 23:59:59');
     }
 
     private static function daysBeforeExpiration(string $date): string
     {
-        $date = \DateTime::createFromFormat('d/m/Y', '01/'.$date);
+        $date = \DateTimeImmutable::createFromFormat('d/m/Y', '01/'.$date);
 
-        return (new \DateTime())->diff($date->modify('last day of this month 23:59:59'))->format('in %R%a days');
+        return (new \DateTimeImmutable())->diff($date->modify('last day of this month 23:59:59'))->format('in %R%a days');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -114,15 +114,15 @@ private static function formatFileSize(string $path): string`
`114`	`114`
`115`	`115`	`private static function isExpired(string $date): bool`
`116`	`116`	`{`
`117`		`- $date = \DateTime::createFromFormat('d/m/Y', '01/'.$date);`
	`117`	`+ $date = \DateTimeImmutable::createFromFormat('d/m/Y', '01/'.$date);`
`118`	`118`
`119`		`- return false !== $date && new \DateTime() > $date->modify('last day of this month 23:59:59');`
	`119`	`+ return false !== $date && new \DateTimeImmutable() > $date->modify('last day of this month 23:59:59');`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`private static function daysBeforeExpiration(string $date): string`
`123`	`123`	`{`
`124`		`- $date = \DateTime::createFromFormat('d/m/Y', '01/'.$date);`
	`124`	`+ $date = \DateTimeImmutable::createFromFormat('d/m/Y', '01/'.$date);`
`125`	`125`
`126`		`- return (new \DateTime())->diff( 44AC $date->modify('last day of this month 23:59:59'))->format('in %R%a days');`
	`126`	`+ return (new \DateTimeImmutable())->diff($date->modify('last day of this month 23:59:59'))->format('in %R%a days');`
`127`	`127`	`}`
`128`	`128`	`}`