Throw exception for the short factory notation

vudaltsov · vudaltsov · commit 81ead82a14e4 · 2017-11-17T00:57:31.000+03:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php b/src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php
@@ -11,7 +11,7 @@
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator\Traits;
 
-use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 
 trait FactoryTrait
 {
@@ -25,8 +25,7 @@ trait FactoryTrait
     final public function factory($factory)
     {
         if (is_string($factory) && 1 === substr_count($factory, ':')) {
-            $factory = explode(':', $factory);
-            $factory[0] = new Reference($factory[0]);
+            throw new InvalidArgumentException('The short factory notation is not supported by the PHP-based DI configuration.');
         }
 
         $this->definition->setFactory(static::processValue($factory, true));

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\DependencyInjection\Loader\Configurator\Traits;`
`13`	`13`
`14`		`-use Symfony\Component\DependencyInjection\Reference;`
	`14`	`+use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;`
`15`	`15`
`16`	`16`	`trait FactoryTrait`
`17`	`17`	`{`
`@@ -25,8 +25,7 @@ trait FactoryTrait`
`25`	`25`	`final public function factory($factory)`
`26`	`26`	`{`
`27`	`27`	`if (is_string($factory) && 1 === substr_count($factory, ':')) {`
`28`		`- $factory = explode(':', $factory);`
`29`		`- $factory[0] = new Reference($factory[0]);`
	`28`	`+ throw new InvalidArgumentException('The short factory notation is not supported by the PHP-based DI configuration.');`
`30`	`29`	`}`
`31`	`30`
`32`	`31`	`$this->definition->setFactory(static::processValue($factory, true));`