Throw exception for the short factory notation

vudaltsov · vudaltsov · commit 81ead82a14e4 · 2017-11-17T00:57:31.000+03:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php b/src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php
@@ -11,7 +11,7 @@
 
 namespace Symfony\Component\DependencyInjection\Loader\Configurator\Traits;
 
-use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 
 trait FactoryTrait
 {
@@ -25,8 +25,7 @@ trait FactoryTrait
     final public function factory($factory)
     {
         if (is_string($factory) && 1 === substr_count($factory, ':')) {
-            $factory = explode(':', $factory);
-            $factory[0] = new Reference($factory[0]);
+            throw new InvalidArgumentException('The short factory notation is not supported by the PHP-based DI configuration.');
         }
 
         $this->definition->setFactory(static::processValue($factory, true));
