minor #17652 [DependencyInjection] Remove unused parameter (dunglas)

fabpot · fabpot · commit 816ecb77ab84 · 2016-02-02T14:48:39.000+01:00
This PR was squashed before being merged into the 3.0 branch (closes #17652). Discussion ---------- [DependencyInjection] Remove unused parameter | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 1a58639 [DependencyInjection] Remove unused parameter
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
@@ -72,7 +72,7 @@ private function inlineArguments(ContainerBuilder $container, array $arguments,
                     continue;
                 }
 
-                if ($this->isInlineableDefinition($container, $id, $definition = $container->getDefinition($id))) {
+                if ($this->isInlineableDefinition($id, $definition = $container->getDefinition($id))) {
                     $this->compiler->addLogMessage($this->formatter->formatInlineService($this, $id, $this->currentId));
 
                     if ($definition->isShared()) {
@@ -100,13 +100,12 @@ private function inlineArguments(ContainerBuilder $container, array $arguments,
     /**
      * Checks if the definition is inlineable.
      *
-     * @param ContainerBuilder $container
-     * @param string           $id
-     * @param Definition       $definition
+     * @param string     $id
+     * @param Definition $definition
      *
      * @return bool If the definition is inlineable
      */
-    private function isInlineableDefinition(ContainerBuilder $container, $id, Definition $definition)
+    private function isInlineableDefinition($id, Definition $definition)
     {
         if (!$definition->isShared()) {
             return true;

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ private function inlineArguments(ContainerBuilder $container, array $arguments,`
`72`	`72`	`continue;`
`73`	`73`	`}`
`74`	`74`
`75`		`- if ($this->isInlineableDefinition($container, $id, $definition = $container->getDefinition($id))) {`
	`75`	`+ if ($this->isInlineableDefinition($id, $definition = $container->getDefinition($id))) {`
`76`	`76`	`$this->compiler->addLogMessage($this->formatter->formatInlineService($this, $id, $this->currentId));`
`77`	`77`
`78`	`78`	`if ($definition->isShared()) {`
`@@ -100,13 +100,12 @@ private function inlineArguments(ContainerBuilder $container, array $arguments,`
`100`	`100`	`/**`
`101`	`101`	`* Checks if the definition is inlineable.`
`102`	`102`	`*`
`103`		`- * @param ContainerBuilder $container`
`104`		`- * @param string $id`
`105`		`- * @param Definition $definition`
	`103`	`+ * @param string $id`
	`104`	`+ * @param Definition $definition`
`106`	`105`	`*`
`107`	`106`	`* @return bool If the definition is inlineable`
`108`	`107`	`*/`
`109`		`- private function isInlineableDefinition(ContainerBuilder $container, $id, Definition $definition)`
	`108`	`+ private function isInlineableDefinition($id, Definition $definition)`
`110`	`109`	`{`
`111`	`110`	`if (!$definition->isShared()) {`
`112`	`111`	`return true;`