[Validator] Simplify NoSuspiciousCharactersValidator

MatTheCat · MatTheCat · commit 816e1fc03cfe · 2024-02-26T12:10:02.000+01:00
diff --git a/src/Symfony/Component/Validator/Constraints/NoSuspiciousCharactersValidator.php b/src/Symfony/Component/Validator/Constraints/NoSuspiciousCharactersValidator.php
@@ -18,7 +18,7 @@
 use Symfony\Component\Validator\Exception\UnexpectedValueException;
 
 /**
- * @author Mathieu Lechat <mathieu.lechat@les-tilleuls.coop>
+ * @author Mathieu Lechat <math.lechat@gmail.com>
  */
 class NoSuspiciousCharactersValidator extends ConstraintValidator
 {
@@ -94,24 +94,12 @@ public function validate(mixed $value, Constraint $constraint): void
 
         $checker->setChecks($checks);
 
-        if (!$checker->isSuspicious($value)) {
-            return;
-        }
-
-        foreach (self::CHECK_ERROR as $check => $error) {
-            if (!($checks & $check)) {
-                continue;
-            }
-
-            $checker->setChecks($check);
-
-            if (!$checker->isSuspicious($value)) {
-                continue;
-            }
+        if ($checker->isSuspicious($value, $error)) {
+            ['messageProperty' => $messageProperty, 'code' => $code] = self::CHECK_ERROR[$error];
 
-            $this->context->buildViolation($constraint->{$error['messageProperty']})
+            $this->context->buildViolation($constraint->$messageProperty)
                 ->setParameter('{{ value }}', $this->formatValue($value))
-                ->setCode($error['code'])
+                ->setCode($code)
                 ->addViolation()
             ;
         }
