bug #50266 [HttpFoundation] Fix file streaming after connection aborted (rlshukhov)

nicolas-grekas · nicolas-grekas · commit 8048ab56f002 · 2023-05-12T10:33:34.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] Fix file streaming after connection aborted | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no After connection aborted HttpFoundation/BinaryFileResponse.php will stream file until it's end. This fix add connection aborted checks. Commits ------- adb9393 [HttpFoundation] Fix file streaming after connection aborted
diff --git a/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php b/src/Symfony/Component/HttpFoundation/BinaryFileResponse.php
@@ -349,7 +349,7 @@ public function sendContent()
                 while ('' !== $data) {
                     $read = fwrite($out, $data);
                     if (false === $read || connection_aborted()) {
-                        break;
+                        break 2;
                     }
                     if (0 < $length) {
                         $length -= $read;

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,7 @@ public function sendContent()`
`349`	`349`	`while ('' !== $data) {`
`350`	`350`	`$read = fwrite($out, $data);`
`351`	`351`	`if (false === $read \|\| connection_aborted()) {`
`352`		`- break;`
	`352`	`+ break 2;`
`353`	`353`	`}`
`354`	`354`	`if (0 < $length) {`
`355`	`355`	`$length -= $read;`