minor #38234 [Intl] fix test by letting mock throw the actual expected exception (xabbuh)

xabbuh · xabbuh · commit 7fa12576efbe · 2020-09-18T16:09:04.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] fix test by letting mock throw the actual expected exception | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #37808 | License | MIT | Doc PR | This fixes a mistake I made when rewriting the tests in #37808. Commits ------- f6f162d fix test by letting mock throw the actual expected exception
diff --git a/src/Symfony/Component/Intl/Tests/Data/Bundle/Reader/BundleEntryReaderTest.php b/src/Symfony/Component/Intl/Tests/Data/Bundle/Reader/BundleEntryReaderTest.php
@@ -144,7 +144,10 @@ public function testFallbackIfLocaleDoesNotExist()
                 [self::RES_DIR, 'en_GB'],
                 [self::RES_DIR, 'en']
             )
-            ->willReturnOnConsecutiveCalls(self::$data, self::$fallbackData);
+            ->willReturnOnConsecutiveCalls(
+                $this->throwException(new ResourceBundleNotFoundException()),
+                self::$fallbackData
+            );
 
         $this->assertSame('Lah', $this->reader->readEntry(self::RES_DIR, 'en_GB', ['Entries', 'Bam']));
     }
@@ -283,7 +286,7 @@ public function testFailIfEntryFoundNeitherInParentNorChild()
                 [self::RES_DIR, 'en_GB'],
                 [self::RES_DIR, 'en']
             )
-            ->willReturnOnConsecutiveCalls(['Foo' => 'Baz'], ['Foo' => 'Baz']);
+            ->willReturnOnConsecutiveCalls(['Foo' => 'Baz'], ['Foo' => 'Bar']);
 
         $this->reader->readEntry(self::RES_DIR, 'en_GB', ['Foo', 'Bar'], true);
     }

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,10 @@ public function testFallbackIfLocaleDoesNotExist()`
`144`	`144`	`[self::RES_DIR, 'en_GB'],`
`145`	`145`	`[self::RES_DIR, 'en']`
`146`	`146`	`)`
`147`		`- ->willReturnOnConsecutiveCalls(self::$data, self::$fallbackData);`
	`147`	`+ ->willReturnOnConsecutiveCalls(`
	`148`	`+ $this->throwException(new ResourceBundleNotFoundException()),`
	`149`	`+ self::$fallbackData`
	`150`	`+ );`
`148`	`151`
`149`	`152`	`$this->assertSame('Lah', $this->reader->readEntry(self::RES_DIR, 'en_GB', ['Entries', 'Bam']));`
`150`	`153`	`}`
`@@ -283,7 +286,7 @@ public function testFailIfEntryFoundNeitherInParentNorChild()`
`283`	`286`	`[self::RES_DIR, 'en_GB'],`
`284`	`287`	`[self::RES_DIR, 'en']`
`285`	`288`	`)`
`286`		`- ->willReturnOnConsecutiveCalls(['Foo' => 'Baz'], ['Foo' => 'Baz']);`
	`289`	`+ ->willReturnOnConsecutiveCalls(['Foo' => 'Baz'], ['Foo' => 'Bar']);`
`287`	`290`
`288`	`291`	`$this->reader->readEntry(self::RES_DIR, 'en_GB', ['Foo', 'Bar'], true);`
`289`	`292`	`}`