8000 minor #42281 [Console] Readd missing php-doc parameter for constructo… · symfony/symfony@7f0641f · GitHub
[go: up one dir, main page]
Skip to content

Commit 7f0641f

Browse files
derrabusderrabus
committed
minor #42281 [Console] Readd missing php-doc parameter for constructor (brosenberger)
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Console] Readd missing php-doc parameter for constructor | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? |no | Deprecations? |no | Tickets | no | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> partly revert the php constroctur php doc (readd missing php-doc for $name and $description) even if they not that meaningfull This is needed as Magento2 uses this library and needs all php-doc parameter for interception compilation. if there are any missing parameters (in this case $name and $description) break compile step as the parameters are missmatching the actual parameters: ![image](https://user-images.githubusercontent.com/2969243/127111853-671d0f70-e44e-4465-9d2b-54ec80b934ff.png) (AbstractConfigOption extends InputOption) Commits ------- 09e7d6f [Console] Readd missing php-doc parameter for constructor
2 parents b68cefa + 09e7d6f commit 7f0641f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

‎src/Symfony/Component/Console/Input/InputOption.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,11 @@ class InputOption
4848
private $description;
4949

5050
/**
51-
* @param string|array|null $shortcut The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
52-
* @param int|null $mode The option mode: One of the VALUE_* constants
53-
* @param string|bool|int|float|array|null $default The default value (must be null for self::VALUE_NONE)
51+
* @param string $name The option name
52+
* @param string|array|null $shortcut The shortcuts, can be null, a string of shortcuts delimited by | or an array of shortcuts
53+
* @param int|null $mode The option mode: One of the VALUE_* constants
54+
* @param string $description A description text
55+
* @param string|bool|int|float|array|null $default The default value (must be null for self::VALUE_NONE)
5456
*
5557
* @throws InvalidArgumentException If option mode is invalid or incompatible
5658
*/

0 commit comments

Comments
 (0)
0