bug #50521 [Serializer] Fix ignoring objects that only implement DenormalizableInterface (spideyfusion)

nicolas-grekas · nicolas-grekas · commit 7e01a328d297 · 2023-06-01T12:13:37.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- [Serializer] Fix ignoring objects that only implement DenormalizableInterface | Q | A | ------------- | --- | Branch? | 6.3  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | N/A  | License | MIT | Doc PR | N/A  When the #49291 optimization got introduced, the `DenormalizableInterface` type was left out of the `CustomNormalizer` normalizer's `getSupportedTypes` implementation. This prevents us for example, implementing custom deserialization logic for API objects where we can't describe all deserialization rules via attributes.  Commits ------- a0a3ce1 [Serializer] Fix ignoring objects that only implement DenormalizableInterface
diff --git a/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
@@ -28,6 +28,7 @@ public function getSupportedTypes(?string $format): array
     {
         return [
             NormalizableInterface::class => __CLASS__ === static::class || $this->hasCacheableSupportsMethod(),
+            DenormalizableInterface::class => __CLASS__ === static::class || $this->hasCacheableSupportsMethod(),
         ];
     }
 
diff --git a/src/Symfony/Component/Serializer/Tests/SerializerTest.php b/src/Symfony/Component/Serializer/Tests/SerializerTest.php
@@ -50,6 +50,7 @@
 use Symfony\Component\Serializer\Tests\Fixtures\Annotations\AbstractDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\Annotations\AbstractDummyFirstChild;
 use Symfony\Component\Serializer\Tests\Fixtures\Annotations\AbstractDummySecondChild;
+use Symfony\Component\Serializer\Tests\Fixtures\DenormalizableDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\DummyFirstChildQuux;
 use Symfony\Component\Serializer\Tests\Fixtures\DummyMessageInterface;
 use Symfony\Component\Serializer\Tests\Fixtures\DummyMessageNumberOne;
@@ -120,6 +121,14 @@ public function testDenormalizeNoMatch()
         $serializer->denormalize('foo', 'stdClass');
     }
 
+    public function testDenormalizeOnObjectThatOnlySupportsDenormalization()
+    {
+        $serializer = new Serializer([new CustomNormalizer()]);
+
+        $obj = $serializer->denormalize('foo', (new DenormalizableDummy())::class, 'xml');
+        $this->assertInstanceOf(DenormalizableDummy::class, $obj);
+    }
+
     public function testDenormalizeOnNormalizer()
     {
         $this->expectException(UnexpectedValueException::class);

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public function getSupportedTypes(?string $format): array`
`28`	`28`	`{`
`29`	`29`	`return [`
`30`	`30`	`NormalizableInterface::class => __CLASS__ === static::class \|\| $this->hasCacheableSupportsMethod(),`
	`31`	`+ DenormalizableInterface::class => __CLASS__ === static::class \|\| $this->hasCacheableSupportsMethod(),`
`31`	`32`	`];`
`32`	`33`	`}`
`33`	`34`