[ErrorHandler] made IDEs and static analysis tools happy

fabpot · fabpot · commit 7dd9dbf28d07 · 2019-06-27T19:50:32.000+02:00
diff --git a/src/Symfony/Component/ErrorCatcher/ErrorRenderer/ErrorRenderer.php b/src/Symfony/Component/ErrorCatcher/ErrorRenderer/ErrorRenderer.php
@@ -62,7 +62,7 @@ public function render($exception, string $format = 'html'): string
             throw new ErrorRendererNotFoundException(sprintf('No error renderer found for format "%s".', $format));
         }
 
-        if (!$exception instanceof FlattenException) {
+        if ($exception instanceof \Exception) {
             $exception = FlattenException::create($exception);
         }
 
diff --git a/src/Symfony/Component/ErrorCatcher/ExceptionHandler.php b/src/Symfony/Component/ErrorCatcher/ExceptionHandler.php
@@ -160,7 +160,7 @@ public function handle(\Exception $exception)
      */
     public function sendPhpResponse($exception)
     {
-        if (!$exception instanceof FlattenException) {
+        if ($exception instanceof \Exception) {
             $exception = FlattenException::create($exception);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function render($exception, string $format = 'html'): string`
`62`	`62`	`throw new ErrorRendererNotFoundException(sprintf('No error renderer found for format "%s".', $format));`
`63`	`63`	`}`
`64`	`64`
`65`		`- if (!$exception instanceof FlattenException) {`
	`65`	`+ if ($exception instanceof \Exception) {`
`66`	`66`	`$exception = FlattenException::create($exception);`
`67`	`67`	`}`
`68`	`68`
Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ public function handle(\Exception $exception)`
`160`	`160`	`*/`
`161`	`161`	`public function sendPhpResponse($exception)`
`162`	`162`	`{`
`163`		`- if (!$exception instanceof FlattenException) {`
	`163`	`+ if ($exception instanceof \Exception) {`
`164`	`164`	`$exception = FlattenException::create($exception);`
`165`	`165`	`}`
`166`	`166`