8000 Some more fixes · symfony/symfony@7da5258 · GitHub
[go: up one dir, main page]

Skip to content

Commit 7da5258

Browse files
committed
Some more fixes
1 parent 59f3b3e commit 7da5258

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -797,15 +797,23 @@ private function createPackageDefinition($basePath, array $baseUrls, Reference $
797797
throw new \LogicException('An asset package cannot have base URLs and base paths.');
798798
}
799799

800-
$package = new ChildDefinition($baseUrls ? 'assets.url_package' : 'assets.path_package');
800+
if (!$baseUrls) {
801+
$package = new ChildDefinition('assets.path_package');
801802

802-
$package
803+
return $package
804+
->setPublic(false)
805+
->replaceArgument(0, $basePath)
806+
->replaceArgument(1, $version)
807+
;
808+
}
809+
810+
$package = new ChildDefinition('assets.url_package');
811+
812+
return $package
803813
->setPublic(false)
804-
->replaceArgument(0, $baseUrls ?: $basePath)
814+
->replaceArgument(0, $baseUrls)
805815
->replaceArgument(1, $version)
806816
;
807-
808-
return $package;
809817
}
810818

811819
private function createVersion(ContainerBuilder $container, $version, $format, $name)

src/Symfony/Component/Asset/composer.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,12 @@
1919
"php": ">=5.5.9"
2020
},
2121
"suggest": {
22-
"symfony/http-foundation": ""
22+
"symfony/http-foundation": "",
23+
"symfony/http-kernel": ""
2324
},
2425
"require-dev": {
25-
"symfony/http-foundation": "~2.8|~3.0"
26+
"symfony/http-foundation": "~2.8|~3.0",
27+
"symfony/http-kernel": "~2.8|~3.0"
2628
},
2729
"autoload": {
2830
"psr-4": { "Symfony\\Component\\Asset\\": "" },

0 commit comments

Comments
 (0)
0