Review fixes

c960657 · c960657 · commit 7d8f1569443a · 2018-04-20T07:21:16.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/CHANGELOG.md b/src/Symfony/Component/HttpFoundation/CHANGELOG.md
@@ -16,7 +16,7 @@ CHANGELOG
    `IniSizeFileException`, `NoFileException`, `NoTmpDirFileException`, `PartialFileException` to
    handle failed `UploadedFile`.
  * added `MigratingSessionHandler` for migrating between two session handlers without losing sessions
- * added `HeaderUtility`.
+ * added `HeaderUtils`.
 
 4.0.0
 -----
diff --git a/src/Symfony/Component/HttpFoundation/HeaderUtils.php b/src/Symfony/Component/HttpFoundation/HeaderUtils.php
@@ -40,7 +40,7 @@ private function __construct()
      * @return array Nested array with as many levels as there are characters in
      *               $separators
      */
-    public static function split($header, $separators)
+    public static function split(string $header, string $separators)
     {
         $quotedSeparators = preg_quote($separators);
 
@@ -116,7 +116,7 @@ public static function combineParts(array $parts)
         $assoc = array();
         foreach ($parts as $part) {
             $name = strtolower($part[0]);
-            $value = isset($part[1]) ? $part[1] : true;
+            $value = $part[1] ?? true;
             $assoc[$name] = $value;
         }
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/HeaderUtilsTest.php b/src/Symfony/Component/HttpFoundation/Tests/HeaderUtilsTest.php
@@ -64,12 +64,12 @@ public function testJoinAssoc()
 
     public function testQuote()
     {
-        $this->assertEquals('foo', HeaderUtils::quote('foo'));
-        $this->assertEquals('az09!#$%&\'*.^_`|~-', HeaderUtils::quote('az09!#$%&\'*.^_`|~-'));
-        $this->assertEquals('"foo bar"', HeaderUtils::quote('foo bar'));
-        $this->assertEquals('"foo [bar]"', HeaderUtils::quote('foo [bar]'));
-        $this->assertEquals('"foo \"bar\""', HeaderUtils::quote('foo "bar"'));
-        $this->assertEquals('"foo \\\\ bar"', HeaderUtils::quote('foo \\ bar'));
+        $this->assertSame('foo', HeaderUtils::quote('foo'));
+        $this->assertSame('az09!#$%&\'*.^_`|~-', HeaderUtils::quote('az09!#$%&\'*.^_`|~-'));
+        $this->assertSame('"foo bar"', HeaderUtils::quote('foo bar'));
+        $this->assertSame('"foo [bar]"', HeaderUtils::quote('foo [bar]'));
+        $this->assertSame('"foo \"bar\""', HeaderUtils::quote('foo "bar"'));
+        $this->assertSame('"foo \\\\ bar"', HeaderUtils::quote('foo \\ bar'));
     }
 
     public function testUnquote()
