[FrameworkBundle] Show server:run logs by default

nicolas-grekas · nicolas-grekas · commit 7cc6161c765f · 2016-06-25T09:10:45.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
@@ -15,9 +15,12 @@
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Console\Output\ConsoleOutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\Process\PhpExecutableFinder;
+use Symfony\Component\Process\Process;
 use Symfony\Component\Process\ProcessBuilder;
+use Symfony\Component\Process\Exception\RuntimeException;
 
 /**
  * Runs Symfony application using PHP built-in web server.
@@ -113,14 +116,23 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $builder->setWorkingDirectory($documentRoot);
         $builder->setTimeout(null);
         $process = $builder->getProcess();
+        $callback = null;
 
-        if (OutputInterface::VERBOSITY_VERBOSE > $output->getVerbosity()) {
+        if (OutputInterface::VERBOSITY_NORMAL > $output->getVerbosity()) {
             $process->disableOutput();
+        } else {
+            try {
+                $process->setTty(true);
+            } catch (RuntimeException $e) {
+                $callback = function ($type, $buffer) use ($output) {
+                    if (Process::ERR === $type && $output instanceof ConsoleOutputInterface) {
+                        $output = $output->getErrorOutput();
+                    }
+                    $output->write($buffer, false, OutputInterface::OUTPUT_RAW);
+                };
+            }
         }
-
-        $this
-            ->getHelper('process')
-            ->run($output, $process, null, null, OutputInterface::VERBOSITY_VERBOSE);
+        $process->run($callback);
 
         if (!$process->isSuccessful()) {
             $errorMessages = array('Built-in server terminated unexpectedly.');
