minor #10160 [Translation] [Loader] Add INI_SCANNER_RAW to parse ini files (TeLiXj)

fabpot · fabpot · commit 7c3a3e11cfdf · 2014-02-01T17:52:05.000+01:00
This PR was merged into the 2.5-dev branch. Discussion ---------- [Translation] [Loader] Add INI_SCANNER_RAW to parse ini files | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR | INI_SCANNER_RAW change the default scanner mode of parse_ini_files to parse all values without evaluate. This allow values with single quotes, "no" and "false" and raise an error if you use the deprecated "#" as comment character. This change is specially good for shared translations, because a translator haven't to know that he can't use a few restricted terms. And has a residual improvement: it's twice fast that use the default value (INI_SCANNER_NORMAL) in my tests Commits ------- 5ef60f1 [Translation] [Loader] Add INI_SCANNER_RAW to parse ini files
diff --git a/src/Symfony/Component/Translation/Loader/IniFileLoader.php b/src/Symfony/Component/Translation/Loader/IniFileLoader.php
@@ -35,7 +35,7 @@ public function load($resource, $locale, $domain = 'messages')
             throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));
         }
 
-        $messages = parse_ini_file($resource, true);
+        $messages = parse_ini_file($resource, true, INI_SCANNER_RAW);
 
         $catalogue = parent::load($messages, $locale, $domain);
         $catalogue->addResource(new FileResource($resource));

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function load($resource, $locale, $domain = 'messages')`
`35`	`35`	`throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));`
`36`	`36`	`}`
`37`	`37`
`38`		`- $messages = parse_ini_file($resource, true);`
	`38`	`+ $messages = parse_ini_file($resource, true, INI_SCANNER_RAW);`
`39`	`39`
`40`	`40`	`$catalogue = parent::load($messages, $locale, $domain);`
`41`	`41`	`$catalogue->addResource(new FileResource($resource));`