Remove node name assertion.

bburnichon · bburnichon · commit 7be490f9bb0d · 2017-04-05T10:09:51.000+02:00
diff --git a/src/Symfony/Component/Config/Definition/ArrayNode.php b/src/Symfony/Component/Config/Definition/ArrayNode.php
@@ -159,8 +159,6 @@ public function setIgnoreExtraKeys($boolean, $remove = true)
      */
     public function setName($name)
     {
-        $this->assertNameIsValid($name);
-
         $this->name = $name;
     }
 
diff --git a/src/Symfony/Component/Config/Definition/BaseNode.php b/src/Symfony/Component/Config/Definition/BaseNode.php
@@ -47,12 +47,9 @@ abstract class BaseNode implements NodeInterface
      */
     public function __construct($name, NodeInterface $parent = null, $pathSeparator = self::DEFAULT_PATH_SEPARATOR)
     {
-        $this->pathSeparator = $pathSeparator;
-
-        $this->assertNameIsValid($name);
-
         $this->name = $name;
         $this->parent = $parent;
+        $this->pathSeparator = $pathSeparator;
     }
 
     public function setAttribute($key, $value)
@@ -356,18 +353,4 @@ abstract protected function mergeValues($leftSide, $rightSide);
      * @return mixed The finalized value
      */
     abstract protected function finalizeValue($value);
-
-    /**
-     * Assert Given Node name is valid.
-     *
-     * @param string $name
-     *
-     * @throws \InvalidArgumentException if name contains path separator.
-     */
-    protected function assertNameIsValid($name)
-    {
-        if (false !== strpos($name, $this->pathSeparator)) {
-            throw new \InvalidArgumentException('The name must not contain "'.$this->pathSeparator.'".');
-        }
-    }
 }
diff --git a/src/Symfony/Component/Config/Definition/VariableNode.php b/src/Symfony/Component/Config/Definition/VariableNode.php
@@ -69,8 +69,6 @@ public function setAllowEmptyValue($boolean)
      */
     public function setName($name)
     {
-        $this->assertNameIsValid($name);
-
         $this->name = $name;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -159,8 +159,6 @@ public function setIgnoreExtraKeys($boolean, $remove = true)`
`159`	`159`	`*/`
`160`	`160`	`public function setName($name)`
`161`	`161`	`{`
`162`		`- $this->assertNameIsValid($name);`
`163`		`-`
`164`	`162`	`$this->name = $name;`
`165`	`163`	`}`
`166`	`164`
Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,6 @@ public function setAllowEmptyValue($boolean)`
`69`	`69`	`*/`
`70`	`70`	`public function setName($name)`
`71`	`71`	`{`
`72`		`- $this->assertNameIsValid($name);`
`73`		`-`
`74`	`72`	`$this->name = $name;`
`75`	`73`	`}`
`76`	`74`