[PropertyInfo] Fix array caching

GuilhemN · GuilhemN · commit 7bc58bf1c5e2 · 2016-07-29T20:50:35.000+02:00
`null` values aren't cached because of the use of `isset`
diff --git a/src/Symfony/Component/PropertyInfo/PropertyInfoCacheExtractor.php b/src/Symfony/Component/PropertyInfo/PropertyInfoCacheExtractor.php
@@ -108,7 +108,7 @@ private function extract($method, array $arguments)
 
         $key = $this->escape($method.'.'.$serializedArguments);
 
-        if (isset($this->arrayCache[$key])) {
+        if (array_key_exists($key, $this->arrayCache)) {
             return $this->arrayCache[$key];
         }
 
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/NullExtractor.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/NullExtractor.php
@@ -79,7 +79,7 @@ public function getProperties($class, array $context = array())
     private function assertIsString($string)
     {
         if (!is_string($string)) {
-            throw new \Exception(sprintf('"%s" expects strings, given "%s".', __CLASS__, gettype($string)));
+            throw new \InvalidArgumentException(sprintf('"%s" expects strings, given "%s".', __CLASS__, gettype($string)));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ private function extract($method, array $arguments)`
`108`	`108`
`109`	`109`	`$key = $this->escape($method.'.'.$serializedArguments);`
`110`	`110`
`111`		`- if (isset($this->arrayCache[$key])) {`
	`111`	`+ if (array_key_exists($key, $this->arrayCache)) {`
`112`	`112`	`return $this->arrayCache[$key];`
`113`	`113`	`}`
`114`	`114`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public function getProperties($class, array $context = array())`
`79`	`79`	`private function assertIsString($string)`
`80`	`80`	`{`
`81`	`81`	`if (!is_string($string)) {`
`82`		`- throw new \Exception(sprintf('"%s" expects strings, given "%s".', __CLASS__, gettype($string)));`
	`82`	`+ throw new \InvalidArgumentException(sprintf('"%s" expects strings, given "%s".', __CLASS__, gettype($string)));`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`	`}`