feature #35815 [Validator] Allow Sequentially constraints on classes + target guards (ogizanagi)

nicolas-grekas · nicolas-grekas · commit 7b89d1b00467 · 2020-02-25T14:41:21.000+01:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [Validator] Allow Sequentially constraints on classes + target guards | Q | A | ------------- | --- | Branch? | master  | Bug fix? | no | New feature? | yes  | Deprecations? | no  | Tickets | N/A  | License | MIT | Doc PR | todo in symfony/symfony-docs#13206 if not merged yet There is no reason to limit this constraint to properties, so let's add classes as targets. Additionally, let's ensure embedded constraints matches allowed targets too. Commits ------- 1e02a96 [Validator] Allow Sequentially constraints on classes
diff --git a/src/Symfony/Component/Validator/Constraints/Sequentially.php b/src/Symfony/Component/Validator/Constraints/Sequentially.php
@@ -16,7 +16,7 @@
  * Validation for the nested constraints collection will stop at first violation.
  *
  * @Annotation
- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})
+ * @Target({"CLASS", "PROPERTY", "METHOD", "ANNOTATION"})
  *
  * @author Maxime Steinhausser <maxime.steinhausser@gmail.com>
  */
@@ -38,4 +38,9 @@ protected function getCompositeOption()
     {
         return 'constraints';
     }
+
+    public function getTargets()
+    {
+        return [self::CLASS_CONSTRAINT, self::PROPERTY_CONSTRAINT];
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`* Validation for the nested constraints collection will stop at first violation.`
`17`	`17`	`*`
`18`	`18`	`* @Annotation`
`19`		`- * @Target({"PROPERTY", "METHOD", "ANNOTATION"})`
	`19`	`+ * @Target({"CLASS", "PROPERTY", "METHOD", "ANNOTATION"})`
`20`	`20`	`*`
`21`	`21`	`* @author Maxime Steinhausser <maxime.steinhausser@gmail.com>`
`22`	`22`	`*/`
`@@ -38,4 +38,9 @@ protected function getCompositeOption()`
`38`	`38`	`{`
`39`	`39`	`return 'constraints';`
`40`	`40`	`}`
	`41`	`+`
	`42`	`+ public function getTargets()`
	`43`	`+ {`
	`44`	`+ return [self::CLASS_CONSTRAINT, self::PROPERTY_CONSTRAINT];`
	`45`	`+ }`
`41`	`46`	`}`