bug #29584 [FrameworkBundle] fix describing routes with no controllers (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 7a34a78be681 · 2018-12-12T18:36:44.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] fix describing routes with no controllers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted by @jpauli during a training. Commits ------- a1c612a [FrameworkBundle] fix describing routes with no controllers
diff --git a/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php b/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
@@ -56,7 +56,7 @@ protected function describeRouteCollection(RouteCollection $routes, array $optio
 
             if ($showControllers) {
                 $controller = $route->getDefault('_controller');
-                $row[] = $this->formatCallable($controller);
+                $row[] = $controller ? $this->formatCallable($controller) : '';
             }
 
             $tableRows[] = $row;

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ protected function describeRouteCollection(RouteCollection $routes, array $optio`
`56`	`56`
`57`	`57`	`if ($showControllers) {`
`58`	`58`	`$controller = $route->getDefault('_controller');`
`59`		`- $row[] = $this->formatCallable($controller);`
	`59`	`+ $row[] = $controller ? $this->formatCallable($controller) : '';`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`$tableRows[] = $row;`