8000 review code · symfony/symfony@79fa925 · GitHub
[go: up one dir, main page]
Skip to content

Commit 79fa925

Browse files
julien57xabbuh
julien57
authored and
xabbuh
committed
review code
1 parent c5c20c5 commit 79fa925

File tree

5 files changed

+5
-16
lines changed

5 files changed

+5
-16
lines changed

‎src/Symfony/Component/HttpFoundation/AcceptHeaderItem.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ public function getAttributes()
163163
/**
164164
* Set an attribute.
165165
*
166-
* @param string $name
167166
* @param string|float $value
168167
*
169168
* @return $this

‎src/Symfony/Component/HttpFoundation/File/UploadedFile.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ public function isValid()
165165
* Moves the file to a new location.
166166
*
167167
* @param string $directory The destination folder
168-
* @param string $name The new file name
168+
* @param string|null $name The new file name
169169
10BC0 *
170170
* @return File A File object representing the new file
171171
*

‎src/Symfony/Component/HttpFoundation/Request.php‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1191,8 +1191,6 @@ public function getHost()
11911191

11921192
/**
11931193
* Sets the request method.
1194-
*
1195-
* @param string $method
11961194
*/
11971195
public function setMethod(string $method)
11981196
{
@@ -1383,8 +1381,6 @@ public function getContentType()
13831381

13841382
/**
13851383
* Sets the default locale.
1386-
*
1387-
* @param string $locale
13881384
*/
13891385
public function setDefaultLocale(string $locale)
13901386
{
@@ -1407,8 +1403,6 @@ public function getDefaultLocale()
14071403

14081404
/**
14091405
* Sets the locale.
1410-
*
1411-
* @param string $locale
14121406
*/
14131407
public function setLocale(string $locale)
14141408
{

‎src/Symfony/Component/HttpFoundation/Session/Storage/Handler/NullSessionHandler.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ public function updateTimestamp($sessionId, $data)
5353
/**
5454
* {@inheritdoc}
5555
*/
56-
protected function doWrite($sessionId, $data)
56+
protected function doWrite(string $sessionId, string $data)
5757
{
5858
return true;
5959
}
6060

6161
/**
6262
* {@inheritdoc}
6363
*/
64-
protected function doDestroy($sessionId)
64+
protected function doDestroy(string $sessionId)
6565
{
6666
return true;
6767
}

‎src/Symfony/Component/HttpFoundation/Session/Storage/Proxy/AbstractProxy.php‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,9 @@ public function getId()
8181
/**
8282
* Sets the session ID.
8383
*
84-
* @param string $id
85-
*
8684
* @throws \LogicException
8785
*/
88-
public function setId($id)
86+
public function setId(string $id)
8987
{
9088
if ($this->isActive()) {
9189
throw new \LogicException('Cannot change the ID of an active session');
@@ -107,11 +105,9 @@ public function getName()
107105
/**
108106
* Sets the session name.
109107
*
110-
* @param string $name
111-
*
112108
* @throws \LogicException
113109
*/
114-
public function setName($name)
110+
public function setName(string $name)
115111
{
116112
if ($this->isActive()) {
117113
throw new \LogicException('Cannot change the name of an active session');

0 commit comments

Comments
 (0)
0