added comments

Nyholm · Nyholm · commit 799efa9b6434 · 2021-04-02T10:21:16.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php b/src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
@@ -63,6 +63,7 @@ final public function extension(string $namespace, array $config)
 
     /**
      * @param string $namespace Example: "framework", "Symfony\Config\FrameworkConfig"
+     * or string to a class implementing ConfigBuilderInterface.
      */
     final public function extensionBuilder(string $namespace)
     {
@@ -71,8 +72,10 @@ final public function extensionBuilder(string $namespace)
         }
 
         if (class_exists($namespace) && is_subclass_of($namespace, ConfigBuilderInterface::class)) {
+            // If class exists and implements ConfigBuilderInterface
             return new $namespace();
         } elseif ('Symfony\\Config\\' === substr($namespace, 0, 15)) {
+            // Else, see if it starts with Symfony\Config\ and try to get the extension alias.
             $namespace = Container::underscore(substr($namespace, 15, strpos($namespace, '\\', 15) - 15));
         }
 
diff --git a/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php
@@ -75,6 +75,9 @@ public function supports($resource, string $type = null)
         return 'php' === $type;
     }
 
+    /**
+     * Resolve the parameters to the $callback and execute it.
+     */
     private function executeCallback(callable $callback, ContainerConfigurator $containerConfigurator, string $path)
     {
         if (!$callback instanceof \Closure) {

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ final public function extension(string $namespace, array $config)`
`63`	`63`
`64`	`64`	`/**`
`65`	`65`	`* @param string $namespace Example: "framework", "Symfony\Config\FrameworkConfig"`
	`66`	`+ * or string to a class implementing ConfigBuilderInterface.`
`66`	`67`	`*/`
`67`	`68`	`final public function extensionBuilder(string $namespace)`
`68`	`69`	`{`
`@@ -71,8 +72,10 @@ final public function extensionBuilder(string $namespace)`
`71`	`72`	`}`
`72`	`73`
`73`	`74`	`if (class_exists($namespace) && is_subclass_of($namespace, ConfigBuilderInterface::class)) {`
	`75`	`+ // If class exists and implements ConfigBuilderInterface`
`74`	`76`	`return new $namespace();`
`75`	`77`	`} elseif ('Symfony\\Config\\' === substr($namespace, 0, 15)) {`
	`78`	`+ // Else, see if it starts with Symfony\Config\ and try to get the extension alias.`
`76`	`79`	`$namespace = Container::underscore(substr($namespace, 15, strpos($namespace, '\\', 15) - 15));`
`77`	`80`	`}`
`78`	`81`
Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,9 @@ public function supports($resource, string $type = null)`
`75`	`75`	`return 'php' === $type;`
`76`	`76`	`}`
`77`	`77`
	`78`	`+ /**`
	`79`	`+ * Resolve the parameters to the $callback and execute it.`
	`80`	`+ */`
`78`	`81`	`private function executeCallback(callable $callback, ContainerConfigurator $containerConfigurator, string $path)`
`79`	`82`	`{`
`80`	`83`	`if (!$callback instanceof \Closure) {`