bug #17559 [SecurityBundle] Fix HTTP Digest auth not being passed user checker (SamFleming)

fabpot · fabpot · commit 786c485883e0 · 2016-01-27T11:43:22.000+01:00
This PR was merged into the 2.8 branch. Discussion ---------- [SecurityBundle] Fix HTTP Digest auth not being passed user checker | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Wasn't sure if this was a bug so posted here http://stackoverflow.com/q/35022776/727236. However, after comparing the 2.3 branch and 2.8 branch I think it was a bug. When trying to use `http_digest` on Symfony 2.8 you're greeted with the error `Argument 2 passed to Symfony\Component\Security\Core\Authentication\Provider\DaoAuthenticationProvider::__construct() must be an instance of Symfony\Component\Security\Core\User\UserCheckerInterface`. The exact same `security.yml` works fine on v2.3.37. Comparing the branches for the SecurityBundle I found that commit 05be5da1710ab681a04334d58126f8c3d431e3cb added the ability to configure a user checker on a per firewall basis. It seems that this commit seems to have missed updating the HttpDigestFactory (although it did update the other factories such as the [HttpBasicFactory](symfony/security-bundle@05be5da#diff-5f3e10fcc9de40dd09a8f3df3bdc9316)). Testing this in my Symfony 2.8 app now works. However, I haven't been able to figure out what unit tests to write confirming this, does anyone with more experience on the SecurityBundle have any pointers? Commits ------- 517a9a2 Fixed HTTP Digest auth not being passed user checker
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/HttpDigestFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/HttpDigestFactory.php
@@ -29,6 +29,7 @@ public function create(ContainerBuilder $container, $id, $config, $userProvider,
         $container
             ->setDefinition($provider, new DefinitionDecorator('security.authentication.provider.dao'))
             ->replaceArgument(0, new Reference($userProvider))
+            ->replaceArgument(1, new Reference('security.user_checker.'.$id))
             ->replaceArgument(2, $id)
         ;
 

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ public function create(ContainerBuilder $container, $id, $config, $userProvider,`
`29`	`29`	`$container`
`30`	`30`	`->setDefinition($provider, new DefinitionDecorator('security.authentication.provider.dao'))`
`31`	`31`	`->replaceArgument(0, new Reference($userProvider))`
	`32`	`+ ->replaceArgument(1, new Reference('security.user_checker.'.$id))`
`32`	`33`	`->replaceArgument(2, $id)`
`33`	`34`	`;`
`34`	`35`