bug #39270 [Inflector] Fix Notice when argument is empty string (moldman)

derrabus · derrabus · commit 782ee5d1d377 · 2020-12-01T18:03:27.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Inflector] Fix Notice when argument is empty string | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | License | MIT Fixing issue when we call `Inflector` with empty string: ``` \Symfony\Component\Inflector\Inflector::singularize(''); ``` ``` Notice: Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363 PHP Notice: Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363 ... Notice: Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363 PHP Notice: Uninitialized string offset: 0 in src/Symfony/Component/Inflector/Inflector.php on line 363 ``` Fix for 5.1 #39244 Commits ------- 2dfe342 [Inflector] Fix Notice when argument is empty string
diff --git a/src/Symfony/Component/Inflector/Inflector.php b/src/Symfony/Component/Inflector/Inflector.php
@@ -310,6 +310,7 @@ final class Inflector
      * A list of words which should not be inflected, reversed.
      */
     private static $uninflected = [
+        '',
         'atad',
         'reed',
         'kcabdeef',
diff --git a/src/Symfony/Component/Inflector/Tests/InflectorTest.php b/src/Symfony/Component/Inflector/Tests/InflectorTest.php
@@ -320,4 +320,16 @@ public function testPluralize($singular, $expectedPlural)
 
         $this->assertEquals($expectedPlural, $plural);
     }
+
+    public function testPluralizeEmptyString()
+    {
+        $plural = Inflector::pluralize('');
+        $this->assertSame('', $plural);
+    }
+
+    public function testSingularizeEmptyString()
+    {
+        $singular = Inflector::singularize('');
+        $this->assertSame('', $singular);
+    }
 }
