bug #13297 [Process] Fix input reset in WindowsPipes (mpajunen)

fabpot · fabpot · commit 77b68b366cfb · 2015-01-07T13:29:00.000+01:00
This PR was merged into the 2.6 branch. Discussion ---------- [Process] Fix input reset in WindowsPipes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Unsetting the input property causes an E_NOTICE error when the property is checked on line 249 (and is likely unintentional anyway). Commits ------- 4e941e3 [Process] Fix input reset in WindowsPipes
diff --git a/src/Symfony/Component/Process/Pipes/WindowsPipes.php b/src/Symfony/Component/Process/Pipes/WindowsPipes.php
@@ -230,7 +230,7 @@ private function write($blocking, $close)
             if (false === $data || (true === $close && feof($r['input']) && '' === $data)) {
                 // no more data to read on input resource
                 // use an empty buffer in the next reads
-                unset($this->input);
+                $this->input = null;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ private function write($blocking, $close)`
`230`	`230`	`if (false === $data \|\| (true === $close && feof($r['input']) && '' === $data)) {`
`231`	`231`	`// no more data to read on input resource`
`232`	`232`	`// use an empty buffer in the next reads`
`233`		`- unset($this->input);`
	`233`	`+ $this->input = null;`
`234`	`234`	`}`
`235`	`235`	`}`
`236`	`236`