bug #36896 [Config] Removed implicit cast of ReflectionProperty to string (derrabus)

fabpot · fabpot · commit 77a826c8b755 · 2020-05-22T19:04:16.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Config] Removed implicit cast of ReflectionProperty to string | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A PHP 8 does not allow casting `ReflectionProperty` instances to string anymore. Commits ------- 8adbade [Config] Removed implicit cast of ReflectionProperty to string.
diff --git a/src/Symfony/Component/Config/Resource/ReflectionClassResource.php b/src/Symfony/Component/Config/Resource/ReflectionClassResource.php
@@ -139,7 +139,11 @@ private function generateSignature(\ReflectionClass $class)
             $defaults = $class->getDefaultProperties();
 
             foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC | \ReflectionProperty::IS_PROTECTED) as $p) {
-                yield $p->getDocComment().$p;
+                yield $p->getDocComment();
+                yield $p->isDefault() ? '<default>' : '';
+                yield $p->isPublic() ? 'public' : 'protected';
+                yield $p->isStatic() ? 'static' : '';
+                yield '$'.$p->name;
                 yield print_r(isset($defaults[$p->name]) && !\is_object($defaults[$p->name]) ? $defaults[$p->name] : null, true);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,11 @@ private function generateSignature(\ReflectionClass $class)`
`139`	`139`	`$defaults = $class->getDefaultProperties();`
`140`	`140`
`141`	`141`	`foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC \| \ReflectionProperty::IS_PROTECTED) as $p) {`
`142`		`- yield $p->getDocComment().$p;`
	`142`	`+ yield $p->getDocComment();`
	`143`	`+ yield $p->isDefault() ? '<default>' : '';`
	`144`	`+ yield $p->isPublic() ? 'public' : 'protected';`
	`145`	`+ yield $p->isStatic() ? 'static' : '';`
	`146`	`+ yield '$'.$p->name;`
`143`	`147`	`yield print_r(isset($defaults[$p->name]) && !\is_object($defaults[$p->name]) ? $defaults[$p->name] : null, true);`
`144`	`148`	`}`
`145`	`149`	`}`