Add scalar typehints/return types to Dotenv

chalasr · chalasr · commit 779c38c87363 · 2017-06-22T12:46:58.000+02:00
diff --git a/src/Symfony/Component/Dotenv/Dotenv.php b/src/Symfony/Component/Dotenv/Dotenv.php
@@ -45,7 +45,7 @@ final class Dotenv
      * @throws FormatException when a file has a syntax error
      * @throws PathException   when a file does not exist or is not readable
      */
-    public function load($path, ...$paths)
+    public function load($path, string ...$paths): void
     {
         array_unshift($paths, $path);
 
@@ -65,7 +65,7 @@ public function load($path, ...$paths)
      *
      * @param array $values An array of env variables
      */
-    public function populate($values)
+    public function populate(array $values): void
     {
         foreach ($values as $name => $value) {
             if (isset($_ENV[$name]) || isset($_SERVER[$name]) || false !== getenv($name)) {
@@ -88,7 +88,7 @@ public function populate($values)
      *
      * @throws FormatException when a file has a syntax error
      */
-    public function parse($data, $path = '.env')
+    public function parse(string $data, string $path = '.env')
     {
         $this->path = $path;
         $this->data = str_replace(array("\r\n", "\r"), "\n", $data);

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ final class Dotenv`
`45`	`45`	`* @throws FormatException when a file has a syntax error`
`46`	`46`	`* @throws PathException when a file does not exist or is not readable`
`47`	`47`	`*/`
`48`		`- public function load($path, ...$paths)`
	`48`	`+ public function load($path, string ...$paths): void`
`49`	`49`	`{`
`50`	`50`	`array_unshift($paths, $path);`
`51`	`51`
`@@ -65,7 +65,7 @@ public function load($path, ...$paths)`
`65`	`65`	`*`
`66`	`66`	`* @param array $values An array of env variables`
`67`	`67`	`*/`
`68`		`- public function populate($values)`
	`68`	`+ public function populate(array $values): void`
`69`	`69`	`{`
`70`	`70`	`foreach ($values as $name => $value) {`
`71`	`71`	`if (isset($_ENV[$name]) \|\| isset($_SERVER[$name]) \|\| false !== getenv($name)) {`
`@@ -88,7 +88,7 @@ public function populate($values)`
`88`	`88`	`*`
`89`	`89`	`* @throws FormatException when a file has a syntax error`
`90`	`90`	`*/`
`91`		`- public function parse($data, $path = '.env')`
	`91`	`+ public function parse(string $data, string $path = '.env')`
`92`	`92`	`{`
`93`	`93`	`$this->path = $path;`
`94`	`94`	`$this->data = str_replace(array("\r\n", "\r"), "\n", $data);`