Revert "bug #24105 [Filesystem] check permissions if dump target dir is missing (xabbuh)"

fabpot · fabpot · commit 7793b797afbb · 2017-09-08T18:12:06.000-07:00
This reverts commit d74144f, reversing changes made to 2b79f48.
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -532,16 +532,6 @@ public function dumpFile($filename, $content, $mode = 0666)
         $dir = dirname($filename);
 
         if (!is_dir($dir)) {
-            $oldCwd = getcwd();
-
-            if (!@chdir(dirname($dir))) {
-                // When the parent directory misses the executable permission bit, we are unable to enter it and thus
-                // cannot check if the target directory exists.
-                throw new IOException(sprintf('Unable to detect if the target directory "%s" exists.', $dir));
-            }
-
-            chdir($oldCwd);
-
             $this->mkdir($dir);
         }
 
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -1102,26 +1102,6 @@ public function testDumpKeepsExistingPermissionsWhenOverwritingAnExistingFile()
         $this->assertFilePermissions(745, $filename);
     }
 
-    /**
-     * @expectedException \Symfony\Component\Filesystem\Exception\IOException
-     * @expectedExceptionMessageRegExp /^Unable to detect if the target directory ".*" exists\.$/
-     */
-    public function testDumpFailsWithExceptionIfExecutablePermissionsForTheParentDirectoryAreMissing()
-    {
-        $this->markAsSkippedIfChmodIsMissing();
-
-        $target = $this->workspace.DIRECTORY_SEPARATOR.'foo';
-        $file = $target.DIRECTORY_SEPARATOR.'foobar';
-        mkdir($target);
-        chmod($this->workspace, 0666);
-
-        if (false !== @chdir($this->workspace)) {
-            $this->markTestSkipped('Test skipped as the used PHP version does not prevent entering directories without the required permissions.');
-        }
-
-        $this->filesystem->dumpFile($file, 'baz');
-    }
-
     public function testCopyShouldKeepExecutionPermission()
     {
         $this->markAsSkippedIfChmodIsMissing();
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTestCase.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTestCase.php
@@ -61,7 +61,6 @@ protected function tearDown()
             $this->longPathNamesWindows = array();
         }
 
-        chmod($this->workspace, 0777);
         $this->filesystem->remove($this->workspace);
         umask($this->umask);
     }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ protected function tearDown()`
`61`	`61`	`$this->longPathNamesWindows = array();`
`62`	`62`	`}`
`63`	`63`
`64`		`- chmod($this->workspace, 0777);`
`65`	`64`	`$this->filesystem->remove($this->workspace);`
`66`	`65`	`umask($this->umask);`
`67`	`66`	`}`