8000 minor #29421 [TwigBundle] Sync tab navigation css (ro0NL) · symfony/symfony@76fc833 · GitHub
[go: up one dir, main page]
Skip to content

Commit 76fc833

Browse files
nicolas-grekasnicolas-grekas
committed
minor #29421 [TwigBundle] Sync tab navigation css (ro0NL)
This PR was merged into the 4.2 branch. Discussion ---------- [TwigBundle] Sync tab navigation css | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> The exception panel in the profiler loads the css from the twig bundle, and is effectively overriding the profiler css. This solves tab navigation. Which got broken due dark theming. Before (hovered 2nd tab) ![image](https://user-images.githubusercontent.com/1047696/49338850-fc309580-f627-11e8-9c15-4e6ffee48b0c.png) After ![image](https://user-images.githubusercontent.com/1047696/49338828-cf7c7e00-f627-11e8-95a5-6dada5fac319.png) Commits ------- d6704bb [TwigBundle] Sync tab navigation css
2 parents ce16b50 + d6704bb commit 76fc833

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

‎src/Symfony/Bundle/TwigBundle/Resources/views/exception.css.twig‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,15 @@ thead.sf-toggle-content.sf-toggle-visible, tbody.sf-toggle-content.sf-toggle-vis
8484
.sf-toggle-off .icon-open, .sf-toggle-on .icon-close { display: block; }
8585

8686
.tab-navigation { margin: 0 0 1em 0; padding: 0; }
87-
.tab-navigation li { background: #FFF; border: 1px solid #DDD; color: #444; cursor: pointer; display: inline-block; font-size: 16px; margin: 0 0 0 -1px; padding: .5em .75em; z-index: 1; }
88-
.tab-navigation li:hover { background: #EEE; }
89-
.tab-navigation li.disabled { background: #F5F5F5; color: #999; }
90-
.tab-navigation li.active { background: #666; border-color: #666; color: #FAFAFA; z-index: 1100; }
91-
.tab-navigation li .badge { background-color: #F5F5F5; color: #777; display: inline-block; font-size: 14px; font-weight: bold; margin-left: 8px; min-width: 10px; padding: 1px 6px; text-align: center; }
92-
.tab-navigation li:hover .badge { background: #FAFAFA; color: #777; }
93-
.tab-navigation li.active .badge { background-color: #444; color: #FFF; }
94-
.tab-navigation li .badge.status-warning { background: #A46A1F; color: #FFF; }
95-
.tab-navigation li .badge.status-error { background: #B0413E; color: #FFF; }
87+
.tab-navigation li { background: var(--tab-background); border: 1px solid var(--table-border); color: var(--tab-color); cursor: pointer; display: inline-block; font-size: 16px; margin: 0 0 0 -1px; padding: .5em .75em; z-index: 1; }
88+
.tab-navigation li .badge { background-color: var(--base-1); color: var(--base-4); display: inline-block; font-size: 14px; font-weight: bold; margin-left: 8px; min-width: 10px; padding: 1px 6px; text-align: center; white-space: nowrap; }
89+
.tab-navigation li.disabled { background: var(--tab-disabled-background); color: var(--tab-disabled-color); }
90+
.tab-navigation li.active { background: var(--tab-active-background); color: var(--tab-active-color); z-index: 1100; }
91+
.tab-navigation li.active .badge { background-color: var(--base-5); color: var(--base-2); }
9692
.tab-content > *:first-child { margin-top: 0; }
93+
.tab-navigation li .badge.status-warning { background: var(--color-warning); color: #FFF; }
94+
.tab-navigation li .badge.status-error { background: var(--color-error); color: #FFF; }
95+
.sf-tabs .tab:not(:first-child) { display: none; }
9796

9897
[data-filters] { position: relative; }
9998
[data-filtered] { cursor: pointer; }

0 commit comments

Comments
 (0)
0