8000 fix twig bridge tests - use strict comparison · symfony/symfony@7504dde · GitHub
[go: up one dir, main page]

Skip to content

Commit 7504dde

Browse files
committed
fix twig bridge tests - use strict comparison
1 parent bb386ab commit 7504dde

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
{%- endblock textarea_widget -%}
3636

3737
{%- block choice_widget -%}
38-
{% if 'hidden' == widget %}
38+
{% if widget is defined and 'hidden' == widget %}
3939
{{- block('hidden_widget') -}}
40-
{% elseif 'text' == widget %}
40+
{% elseif widget is defined and 'text' == widget %}
4141
{{- block('form_widget_simple') -}}
4242
{% elseif expanded %}
4343
{{- block('choice_widget_expanded') -}}

src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
6161
$choiceList = $this->createChoiceList($options);
6262
$builder->setAttribute('choice_list', $choiceList);
6363

64-
if ($options['expanded'] && !in_array($options['widget'], array('text', 'hidden'))) {
64+
if ($options['expanded'] && !in_array($options['widget'], array('text', 'hidden'), true)) {
6565
$builder->setDataMapper($options['multiple']
6666
? new CheckboxListMapper($choiceList)
6767
: new RadioListMapper($choiceList));
@@ -151,7 +151,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
151151
$builder->addViewTransformer(new ChoicesToValuesTransformer($choiceList));
152152

153153
// for "text" / "hidden" widget, view data uses a delimiter
154-
if (in_array($options['widget'], array('text', 'hidden'))) {
154+
if (in_array($options['widget'], array('text', 'hidden'), true)) {
155155
$builder->addViewTransformer(new ValuesToStringTransformer($options['delimiter'], $options['trim']));
156156
}
157157
} else {
@@ -195,7 +195,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
195195
'choice_translation_domain' => $choiceTranslationDomain,
196196
));
197197

198-
if (in_array($options['widget'], array('text', 'hidden'))) {
198+
if (in_array($options['widget'], array('text', 'hidden'), true)) {
199199
return;
200200
}
201201

@@ -237,7 +237,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
237237
*/
238238
public function finishView(FormView $view, FormInterface $form, array $options)
239239
{
240-
if (in_array($options['widget'], array('text', 'hidden'))) {
240+
if (in_array($options['widget'], array('text', 'hidden'), true)) {
241241
return;
242242
}
243243

@@ -318,8 +318,8 @@ public function configureOptions(OptionsResolver $resolver)
318318
};
319319

320320
$multipleNormalizer = function (Options $options, $multiple) {
321-
if (in_array($options['widget'], array('radio', 'checkbox'))) {
322-
return 'checkbox' == $options['widget'];
321+
if (in_array($options['widget'], array('radio', 'checkbox'), true)) {
322+
return 'checkbox' === $options['widget'];
323323
}
324324

325325
return $multiple;
@@ -332,7 +332,7 @@ public function configureOptions(OptionsResolver $resolver)
332332
$expanded = false;
333333
}
334334

335-
return in_array($options['widget'], array('radio', 'checkbox')) ?: $expanded;
335+
return in_array($options['widget'], array('radio', 'checkbox'), true) ?: $expanded;
336336
};
337337

338338
$resolver->setDefaults(array(
@@ -376,6 +376,7 @@ public function configureOptions(OptionsResolver $resolver)
376376
$resolver->setAllowedTypes('choice_attr', array('null', 'array', 'callable', 'string', 'Symfony\Component\PropertyAccess\PropertyPath'));
377377
$resolver->setAllowedTypes('preferred_choices', array('array', '\Traversable', 'callable', 'string', 'Symfony\Component\PropertyAccess\PropertyPath'));
378378
$resolver->setAllowedTypes('group_by', array('null', 'array', '\Traversable', 'string', 'callable', 'string', 'Symfony\Component\PropertyAccess\PropertyPath'));
379+
$resolver->setAllowedValues('widget', array(null, 'hidden', 'text', 'select', 'checkbox', 'radio'));
379380
}
380381

381382
/**

0 commit comments

Comments
 (0)
0