minor #22086 Release memory for the parsed data after parsing (stof)

fabpot · fabpot · commit 749451ed59da · 2017-03-21T07:21:25.000-07:00
This PR was merged into the 3.3-dev branch. Discussion ---------- Release memory for the parsed data after parsing | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a If the Dotenv instance outlives the parsing of the file (which is the case easily in the usage described in the documentation as it is used in the global scope and so the variable does not go out of scope until the end of the process), there is no reason to keep the parsed data in memory after the end of the parsing. I have not reset the integer properties, as this would not save any memory anyway (integers are inline inside the ZVAL anyway) Commits ------- 518f618 Release memory for the parsed data after parsing
diff --git a/src/Symfony/Component/Dotenv/Dotenv.php b/src/Symfony/Component/Dotenv/Dotenv.php
@@ -121,6 +121,8 @@ public function parse($data, $path = '.env')
             return $this->values;
         } finally {
             $this->values = array();
+            $this->data = null;
+            $this->path = null;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,8 @@ public function parse($data, $path = '.env')`
`121`	`121`	`return $this->values;`
`122`	`122`	`} finally {`
`123`	`123`	`$this->values = array();`
	`124`	`+ $this->data = null;`
	`125`	`+ $this->path = null;`
`124`	`126`	`}`
`125`	`127`	`}`
`126`	`128`