Add generics to ArgumentMetadata::getAttributes

Seldaek · Seldaek · commit 7475c242d3c2 · 2022-03-16T17:03:24.000+01:00
diff --git a/src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadata.php b/src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadata.php
@@ -101,14 +101,27 @@ public function getDefaultValue(): mixed
     }
 
     /**
-     * @return object[]
+     * @param class-string $name
+     * @param self::IS_INSTANCEOF|0 $flags
+     * @return array<object>
      */
     public function getAttributes(string $name = null, int $flags = 0): array
     {
         if (!$name) {
             return $this->attributes;
         }
 
+        return $this->getAttributesOfType($name, $flags);
+    }
+
+    /**
+     * @template T of object
+     * @param class-string<T> $name
+     * @param self::IS_INSTANCEOF|0 $flags
+     * @return array<T>
+     */
+    public function getAttributesOfType(string $name, int $flags = 0): array
+    {
         $attributes = [];
         if ($flags & self::IS_INSTANCEOF) {
             foreach ($this->attributes as $attribute) {
diff --git a/src/Symfony/Component/HttpKernel/Tests/ControllerMetadata/ArgumentMetadataTest.php b/src/Symfony/Component/HttpKernel/Tests/ControllerMetadata/ArgumentMetadataTest.php
@@ -48,4 +48,10 @@ public function testGetAttributes()
         $argument = new ArgumentMetadata('foo', 'string', false, true, 'default value', true, [new Foo('bar')]);
         $this->assertEquals([new Foo('bar')], $argument->getAttributes());
     }
+
+    public function testGetAttributesOfType()
+    {
+        $argument = new ArgumentMetadata('foo', 'string', false, true, 'default value', true, [new Foo('bar')]);
+        $this->assertEquals([new Foo('bar')], $argument->getAttributesOfType(Foo::class));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -48,4 +48,10 @@ public function testGetAttributes()`
`48`	`48`	`$argument = new ArgumentMetadata('foo', 'string', false, true, 'default value', true, [new Foo('bar')]);`
`49`	`49`	`$this->assertEquals([new Foo('bar')], $argument->getAttributes());`
`50`	`50`	`}`
	`51`	`+`
	`52`	`+ public function testGetAttributesOfType()`
	`53`	`+ {`
	`54`	`+ $argument = new ArgumentMetadata('foo', 'string', false, true, 'default value', true, [new Foo('bar')]);`
	`55`	`+ $this->assertEquals([new Foo('bar')], $argument->getAttributesOfType(Foo::class));`
	`56`	`+ }`
`51`	`57`	`}`