Fix a typo and add a check to prevent regressions

GuilhemN · GuilhemN · commit 74378327fc57 · 2016-04-27T19:33:28.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -998,7 +998,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
             $cacheMetadataFactory = new Definition(
                 CacheClassMetadataFactory::class,
                 array(
-                    new Reference('serializer.mapping.class_metadata_factory.inner'),
+                    new Reference('serializer.mapping.cache_class_metadata_factory.inner'),
                     new Reference('cache.pool.serializer'),
                 )
             );
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ContainerDumpTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ContainerDumpTest.php
@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\FrameworkBundle\Tests\Functional;
+
+/**
+ * Checks that the container compiles correctly when all the bundle features are enabled.
+ */
+class ContainerDumpTest extends WebTestCase
+{
+    public function testContainerCompilationInDebug()
+    {
+        $client = $this->createClient(array('test_case' => 'ContainerDump', 'root_config' => 'config.yml'));
+
+        $this->assertTrue($client->getContainer()->has('serializer'));
+    }
+
+    public function testContainerCompilation()
+    {
+        $client = $this->createClient(array('test_case' => 'ContainerDump', 'root_config' => 'config.yml', 'debug' => false));
+
+        $this->assertTrue($client->getContainer()->has('serializer'));
+    }
+}
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/ContainerDump/bundles.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/ContainerDump/bundles.php
@@ -0,0 +1,18 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+use Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\TestBundle;
+use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
+
+return array(
+    new FrameworkBundle(),
+    new TestBundle(),
+);
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/ContainerDump/config.yml b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/ContainerDump/config.yml
@@ -0,0 +1,22 @@
+imports:
+    - { resource: ../config/default.yml }
+
+framework:
+    # Enabled as many thing as possible
+    esi: true
+    ssi: true
+    fragments: true
+    profiler: true
+    router: true
+    session: true
+    request: true
+    templating:
+        enabled: true
+        engines: ['php']
+    assets: true
+    translator: true
+    validation: true
+    serializer: true
+    property_info: true
+    csrf_protection: true
+    form: true

Original file line number	Diff line number	Diff line change
`@@ -998,7 +998,7 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder`
`998`	`998`	`$cacheMetadataFactory = new Definition(`
`999`	`999`	`CacheClassMetadataFactory::class,`
`1000`	`1000`	`array(`
`1001`		`- new Reference('serializer.mapping.class_metadata_factory.inner'),`
	`1001`	`+ new Reference('serializer.mapping.cache_class_metadata_factory.inner'),`
`1002`	`1002`	`new Reference('cache.pool.serializer'),`
`1003`	`1003`	`)`
`1004`	`1004`	`);`