bug #38336 [PhpUnitBridge] Fixed class_alias() for PHPUnit\Framework\Error\Error (stevegrunwell)

fabpot · fabpot · commit 72ff4012a533 · 2020-09-29T08:53:53.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Fixed class_alias() for PHPUnit\Framework\Error\Error | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a PHPUnit 6.x removed the PHPUnit_Framework_* classes in favor of PHP namespaces, but one error class did not map the same as the others: `PHPUnit_Framework_Error`. Instead of mapping to `PHPUnit\Framework\Error` in the same way that `PHPUnit_Framework_Error_Warning` mapped to `PHPUnit\Framework\Error\Warning`, this base class was replaced with `PHPUnit\Framework\Error\Error`, so we cannot map it using simple string replacement like its descendants. Commits ------- 8e607b5 [PhpUnitBridge] Fix class_alias() for PHPUnit\Framework\Error\Error
diff --git a/src/Symfony/Bridge/PhpUnit/Tests/BootstrapTest.php b/src/Symfony/Bridge/PhpUnit/Tests/BootstrapTest.php
@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bridge\PhpUnit\Tests;
+
+use PHPUnit\Framework\TestCase;
+
+class BootstrapTest extends TestCase
+{
+    /**
+     * @requires PHPUnit < 6.0
+     */
+    public function testAliasingOfErrorClasses()
+    {
+        $this->assertInstanceOf(
+            \PHPUnit_Framework_Error::class,
+            new \PHPUnit\Framework\Error\Error('message', 0, __FILE__, __LINE__)
+        );
+        $this->assertInstanceOf(
+            \PHPUnit_Framework_Error_Deprecated::class,
+            new \PHPUnit\Framework\Error\Deprecated('message', 0, __FILE__, __LINE__)
+        );
+        $this->assertInstanceOf(
+            \PHPUnit_Framework_Error_Notice::class,
+            new \PHPUnit\Framework\Error\Notice('message', 0, __FILE__, __LINE__)
+        );
+        $this->assertInstanceOf(
+            \PHPUnit_Framework_Error_Warning::class,
+            new \PHPUnit\Framework\Error\Warning('message', 0, __FILE__, __LINE__)
+        );
+    }
+}
diff --git a/src/Symfony/Bridge/PhpUnit/bootstrap.php b/src/Symfony/Bridge/PhpUnit/bootstrap.php
@@ -56,7 +56,6 @@
         'PHPUnit_Framework_Constraint_TraversableContains',
         'PHPUnit_Framework_Constraint_TraversableContainsOnly',
 
-        'PHPUnit_Framework_Error',
         'PHPUnit_Framework_Error_Deprecated',
         'PHPUnit_Framework_Error_Notice',
         'PHPUnit_Framework_Error_Warning',
@@ -100,6 +99,7 @@ class_alias('PHPUnit_Framework_Constraint_And', 'PHPUnit\Framework\Constraint\Lo
     class_alias('PHPUnit_Framework_Constraint_Not', 'PHPUnit\Framework\Constraint\LogicalNot');
     class_alias('PHPUnit_Framework_Constraint_Or', 'PHPUnit\Framework\Constraint\LogicalOr');
     class_alias('PHPUnit_Framework_Constraint_Xor', 'PHPUnit\Framework\Constraint\LogicalXor');
+    class_alias('PHPUnit_Framework_Error', 'PHPUnit\Framework\Error\Error');
 }
 
 // Detect if we need to serialize deprecations to a file.
