bug #28838 [DI] Default undefined env to empty string during compile (ro0NL)

fabpot · fabpot · commit 72ab16d4c942 · 2018-10-17T09:43:06.000+02:00
This PR was squashed before being merged into the 4.1 branch (closes #28838). Discussion ---------- [DI] Default undefined env to empty string during compile | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no  | Deprecations? | no | Tests pass? | yes  | Fixed tickets | #28827 | License | MIT | Doc PR | symfony/symfony-docs#...  Instead of using `null` for undefined envs, use `""` instead. We already default the type to string, so actually providing a string value makes sense. During runtime it will always be string also. Commits ------- 38a8ab9 [DI] Default undefined env to empty string during compile
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ValidateEnvPlaceholdersPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ValidateEnvPlaceholdersPass.php
@@ -48,7 +48,7 @@ public function process(ContainerBuilder $container)
             foreach ($resolvingBag->getEnvPlaceholders() + $resolvingBag->getUnusedEnvPlaceholders() as $env => $placeholders) {
                 $values = array();
                 if (false === $i = strpos($env, ':')) {
-                    $default = $defaultBag->has("env($env)") ? $defaultBag->get("env($env)") : null;
+                    $default = $defaultBag->has("env($env)") ? $defaultBag->get("env($env)") : self::$typeFixtures['string'];
                     $defaultType = null !== $default ? self::getType($default) : 'string';
                     $values[$defaultType] = $default;
                 } else {
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/ValidateEnvPlaceholdersPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/ValidateEnvPlaceholdersPassTest.php
@@ -48,6 +48,7 @@ public function testDefaultEnvWithoutPrefixIsValidatedInConfig()
         $container->registerExtension($ext = new EnvExtension());
         $container->prependExtensionConfig('env_extension', $expected = array(
             'float_node' => '%env(FLOATISH)%',
+            'string_node' => '%env(UNDEFINED)%',
         ));
 
         $this->doProcess($container);
@@ -311,6 +312,14 @@ public function getConfigTreeBuilder()
                 ->arrayNode('simple_array_node')->end()
                 ->enumNode('enum_node')->values(array('a', 'b'))->end()
                 ->variableNode('variable_node')->end()
+                ->scalarNode('string_node')
+                    ->validate()
+                        ->ifTrue(function ($value) {
+                            return !\is_string($value);
+                        })
+                        ->thenInvalid('%s is not a string')
+                    ->end()
+                ->end()
             ->end();
 
         return $treeBuilder;
