minor #23222 [Routing] Fix XmlFileLoader exception message (voronkovich)

fabpot · fabpot · commit 71b61b04a1da · 2017-06-19T07:02:36.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [Routing] Fix XmlFileLoader exception message | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When an `XmlFileLoader` encounters an unknown tag it throws an exception with message like `Unknown tag "foo" used in file "bar". Expected "default", "requirement" or "option".`. A proper message should be `Unknown tag "foo" used in file "bar". Expected "default", "requirement", "option" or "condition".` Commits ------- f6a94cb [Routing] Fix XmlFileLoader exception message
diff --git a/src/Symfony/Component/Routing/Loader/XmlFileLoader.php b/src/Symfony/Component/Routing/Loader/XmlFileLoader.php
@@ -250,7 +250,7 @@ private function parseConfigs(\DOMElement $node, $path)
                     $condition = trim($n->textContent);
                     break;
                 default:
-                    throw new \InvalidArgumentException(sprintf('Unknown tag "%s" used in file "%s". Expected "default", "requirement" or "option".', $n->localName, $path));
+                    throw new \InvalidArgumentException(sprintf('Unknown tag "%s" used in file "%s". Expected "default", "requirement", "option" or "condition".', $n->localName, $path));
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ private function parseConfigs(\DOMElement $node, $path)`
`250`	`250`	`$condition = trim($n->textContent);`
`251`	`251`	`break;`
`252`	`252`	`default:`
`253`		`- throw new \InvalidArgumentException(sprintf('Unknown tag "%s" used in file "%s". Expected "default", "requirement" or "option".', $n->localName, $path));`
	`253`	`+ throw new \InvalidArgumentException(sprintf('Unknown tag "%s" used in file "%s". Expected "default", "requirement", "option" or "condition".', $n->localName, $path));`
`254`	`254`	`}`
`255`	`255`	`}`
`256`	`256`