minor #23322 [Serializer] Improve CircularReference detection message (ScullWM)

fabpot · fabpot · commit 71a69b40d2a7 · 2017-07-03T16:30:36.000+03:00
This PR was merged into the 2.7 branch. Discussion ---------- [Serializer] Improve CircularReference detection message | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Hi, I've get a CircularReferenceException error while serializing object with nested levels. Detect a CircularReference is great, but having more information about the object that generate this exception is better. I simply suggest to add a `get_class` of the current object in the error message. Before: `A circular reference has been detected (configured limit: 1).` After (edit) `A circular reference has been detected when serializing the object of class "App\Domain\User" (configured limit: 1).` Commits ------- 3a529e3 Improve CircularReferenceException message
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -228,7 +228,7 @@ protected function handleCircularReference($object)
             return call_user_func($this->circularReferenceHandler, $object);
         }
 
-        throw new CircularReferenceException(sprintf('A circular reference has been detected (configured limit: %d).', $this->circularReferenceLimit));
+        throw new CircularReferenceException(sprintf('A circular reference has been detected when serializing the object of class "%s" (configured limit: %d)', get_class($object), $this->circularReferenceLimit));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ protected function handleCircularReference($object)`
`228`	`228`	`return call_user_func($this->circularReferenceHandler, $object);`
`229`	`229`	`}`
`230`	`230`
`231`		`- throw new CircularReferenceException(sprintf('A circular reference has been detected (configured limit: %d).', $this->circularReferenceLimit));`
	`231`	`+ throw new CircularReferenceException(sprintf('A circular reference has been detected when serializing the object of class "%s" (configured limit: %d)', get_class($object), $this->circularReferenceLimit));`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`/**`