[Form] Limit allowed types for 'empty_value' TimeType option

kix · kix · commit 7136987fffad · 2014-11-06T23:17:27.000+05:00
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php b/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php
@@ -237,6 +237,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
             'hours' => 'array',
             'minutes' => 'array',
             'seconds' => 'array',
+            'empty_value' => array('string', 'boolean', 'null'),
         ));
     }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php
@@ -730,4 +730,14 @@ public function testThrowExceptionIfSecondsIsInvalid()
             'seconds' => 'bad value',
         ));
     }
+
+    /**
+     * @expectedException \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
+     */
+    public function testThrowExceptionIfEmptyValueIsInvalid()
+    {
+        $this->factory->create('time', null, array(
+            'empty_value' => array(),
+        ));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)`
`237`	`237`	`'hours' => 'array',`
`238`	`238`	`'minutes' => 'array',`
`239`	`239`	`'seconds' => 'array',`
	`240`	`+ 'empty_value' => array('string', 'boolean', 'null'),`
`240`	`241`	`));`
`241`	`242`	`}`
`242`	`243`