10000 feature #19824 [Console] Add ability to regress the ProgressBar (jame… · symfony/symfony@7136247 · GitHub
[go: up one dir, main page]
Skip to content

Commit 7136247

Browse files
fabpotfabpot
committed
feature #19824 [Console] Add ability to regress the ProgressBar (jameshalsall)
This PR was merged into the 3.2-dev branch. Discussion ---------- [Console] Add ability to regress the ProgressBar | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15227 | License | MIT | Doc PR | https://github.com/symfony/symfony-docs/pull/6949/files Commits ------- 42971bb [Console] Add ability to regress the ProgressBar
2 parents c69b89a + 42971bb commit 7136247

File tree

2 files changed

+73
-19
lines changed

2 files changed

+73
-19
lines changed

‎src/Symfony/Component/Console/Helper/ProgressBar.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,6 @@ public function start($max = null)
339339
* Advances the progress output X steps.
340340
*
341341
* @param int $step Number of steps to advance
342-
*
343-
* @throws LogicException
344342
*/
345343
public function advance($step = 1)
346344
{
@@ -361,18 +359,15 @@ public function setOverwrite($overwrite)
361359
* Sets the current progress.
362360
*
363361
* @param int $step The current progress
364-
*
365-
* @throws LogicException
366362
*/
367363
public function setProgress($step)
368364
{
369365
$step = (int) $step;
370-
if ($step < $this->step) {
371-
throw new LogicException('You can\'t regress the progress bar.');
372-
}
373366

374367
if ($this->max && $step > $this->max) {
375368
$this->max = $step;
369+
} elseif ($step < 0) {
370+
$step = 0;
376371
}
377372

378373
$prevPeriod = (int) ($this->step / $this->redrawFreq);

‎src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php

Lines changed: 71 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,77 @@ public function testAdvanceOverMax()
9696
);
9797
}
9898

99+
public function testRegress()
100+
{
101+
$bar = new ProgressBar($output = $this->getOutputStream());
102+
$bar->start();
103+
$bar->advance();
104+
$bar->advance();
105+
$bar->advance(-1);
106+
107+
rewind($output->getStream());
108+
$this->assertEquals(
109+
' 0 [>---------------------------]'.
110+
$this->generateOutput(' 1 [->--------------------------]').
111+
$this->generateOutput(' 2 [-->-------------------------]').
112+
$this->generateOutput(' 1 [->--------------------------]'),
113+
stream_get_contents($output->getStream())
114+
);
115+
}
116+
117+
public function testRegressWithStep()
118+
{
119+
$bar = new ProgressBar($output = $this->getOutputStream());
120+
$bar->start();
121+
$bar->advance(4);
122+
$bar->advance(4);
123+
$bar->advance(-2);
124+
125+
rewind($output->getStream());
126+
$this->assertEquals(
127+
' 0 [>---------------------------]'.
128+
$this->generateOutput(' 4 [---->-----------------------]').
129+
$this->generateOutput(' 8 [-------->-------------------]').
130+
$this->generateOutput(' 6 [------>---------------------]'),
131+
stream_get_contents($output->getStream())
132+
);
133+
}
134+
135+
public function testRegressMultipleTimes()
136+
{
137+
$bar = new ProgressBar($output = $this->getOutputStream());
138+
$bar->start();
139+
$bar->advance(3);
140+
$bar->advance(3);
141+
$bar->advance(-1);
142+
$bar->advance(-2);
143+
144+
rewind($output->getStream());
145+
$this->assertEquals(
146+
' 0 [>---------------------------]'.
147+
$this->generateOutput(' 3 [--->------------------------]').
148+
$this->generateOutput(' 6 [------>---------------------]').
149+
$this->generateOutput(' 5 [----->----------------------]').
150+
$this->generateOutput(' 3 [--->------------------------]'),
151+
stream_get_contents($output->getStream())
152+
);
153+
}
154+
155+
public function testRegressBelowMin()
156+
{
157+
$bar = new ProgressBar($output = $this->getOutputStream(), 10);
158+
$bar->setProgress(1);
159+
$bar->advance(-1);
160+
$bar->advance(-1);
161+
162+
rewind($output->getStream());
163+
$this->assertEquals(
164+
' 1/10 [==>-------------------------] 10%'.
165+
$this->generateOutput(' 0/10 [>---------------------------] 0%'),
166+
stream_get_contents($output->getStream())
167+
);
168+
}
169+
99170
public function testFormat()
100171
{
101172
$expected =
@@ -282,18 +353,6 @@ public function testSetCurrentBeforeStarting()
282353
$this->assertNotNull($bar->getStartTime());
283354
}
284355

285-
/**
286-
* @expectedException \LogicException
287-
* @expectedExceptionMessage You can't regress the progress bar
288-
*/
289-
public function testRegressProgress()
290-
{
291-
$bar = new ProgressBar($output = $this->getOutputStream(), 50);
292-
$bar->start();
293-
$bar->setProgress(15);
294-
$bar->setProgress(10);
295-
}
296-
297356
public function testRedrawFrequency()
298357
{
299358
$bar = $this->getMock('Symfony\Component\Console\Helper\ProgressBar', array('display'), array($this->getOutputStream(), 6));

0 commit comments

Comments
 (0)
0