bug #47145 [HttpClient] Fix shared connections not being freed on PHP < 8 (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 7129a32d9c53 · 2022-08-02T09:15:06.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Fix shared connections not being freed on PHP < 8 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46937 | License | MIT | Doc PR | - Commits ------- cef44af [HttpClient] Fix shared connections not being freed on PHP < 8
diff --git a/src/Symfony/Component/HttpClient/Internal/CurlClientState.php b/src/Symfony/Component/HttpClient/Internal/CurlClientState.php
@@ -96,7 +96,7 @@ public function reset()
         curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_DNS);
         curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_SSL_SESSION);
 
-        if (\defined('CURL_LOCK_DATA_CONNECT')) {
+        if (\defined('CURL_LOCK_DATA_CONNECT') && \PHP_VERSION_ID >= 80000) {
             curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_CONNECT);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function reset()`
`96`	`96`	`curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_DNS);`
`97`	`97`	`curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_SSL_SESSION);`
`98`	`98`
`99`		`- if (\defined('CURL_LOCK_DATA_CONNECT')) {`
	`99`	`+ if (\defined('CURL_LOCK_DATA_CONNECT') && \PHP_VERSION_ID >= 80000) {`
`100`	`100`	`curl_share_setopt($this->share, \CURLSHOPT_SHARE, \CURL_LOCK_DATA_CONNECT);`
`101`	`101`	`}`
`102`	`102`	`}`