bug #37191 [HttpClient] fix offset computation for data chunks (nicolas-grekas)

fabpot · fabpot · commit 7107080675fc · 2020-06-11T08:13:02.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix offset computation for data chunks | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - A minor thingy, still a bugfix. Commits ------- ff05be0 [HttpClient] fix offset computation for data chunks
diff --git a/src/Symfony/Component/HttpClient/Response/ResponseTrait.php b/src/Symfony/Component/HttpClient/Response/ResponseTrait.php
@@ -359,8 +359,9 @@ public static function stream(iterable $responses, float $timeout = null): \Gene
                                 continue;
                             }
 
-                            $response->offset += \strlen($chunk);
+                            $chunkLen = \strlen($chunk);
                             $chunk = new DataChunk($response->offset, $chunk);
+                            $response->offset += $chunkLen;
                         } elseif (null === $chunk) {
                             $e = $multi->handlesActivity[$j][0];
                             unset($responses[$j], $multi->handlesActivity[$j]);
