[Yaml] deprecate parsing mappings without keys

xabbuh · xabbuh · commit 703e810805ab · 2017-02-17T14:03:33.000+01:00
diff --git a/UPGRADE-3.3.md b/UPGRADE-3.3.md
@@ -119,6 +119,8 @@ Workflow
 Yaml
 ----
 
+ * Omitting the key of a mapping is deprecated and will lead to a `ParseException` in Symfony 4.0.
+
  * The constructor arguments `$offset`, `$totalNumberOfLines` and
    `$skippedLineNumbers` of the `Parser` class are deprecated and will be
    removed in 4.0
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -340,6 +340,8 @@ Validator
 Yaml
 ----
 
+ * Omitting the key of a mapping is not supported anymore and throws a `ParseException`.
+
  * Mappings with a colon (`:`) that is not followed by a whitespace are not
    supported anymore and lead to a `ParseException`(e.g. `foo:bar` must be
    `foo: bar`).
diff --git a/src/Symfony/Component/Yaml/CHANGELOG.md b/src/Symfony/Component/Yaml/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+3.3.0
+-----
+
+ * Omitting the key of a mapping is deprecated and will lead to a `ParseException` in Symfony 4.0.
+
 3.2.0
 -----
 
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -481,6 +481,10 @@ private static function parseMapping($mapping, $flags, &$i = 0, $references = ar
                 break;
             }
 
+            if (':' === $key) {
+                @trigger_error('Omitting the key of a mapping is deprecated and will throw a ParseException in 4.0.', E_USER_DEPRECATED);
+            }
+
             if (':' !== $key && (!isset($mapping[$i + 1]) || !in_array($mapping[$i + 1], array(' ', ',', '[', ']', '{', '}'), true))) {
                 @trigger_error('Using a colon that is not followed by an indication character (i.e. " ", ",", "[", "]", "{", "}" is deprecated since version 3.2 and will throw a ParseException in 4.0.', E_USER_DEPRECATED);
             }

Original file line number	Diff line number	Diff line change
`@@ -481,6 +481,10 @@ private static function parseMapping($mapping, $flags, &$i = 0, $references = ar`
`481`	`481`	`break;`
`482`	`482`	`}`
`483`	`483`
	`484`	`+ if (':' === $key) {`
	`485`	`+ @trigger_error('Omitting the key of a mapping is deprecated and will throw a ParseException in 4.0.', E_USER_DEPRECATED);`
	`486`	`+ }`
	`487`	`+`
`484`	`488`	`if (':' !== $key && (!isset($mapping[$i + 1]) \|\| !in_array($mapping[$i + 1], array(' ', ',', '[', ']', '{', '}'), true))) {`
`485`	`489`	`@trigger_error('Using a colon that is not followed by an indication character (i.e. " ", ",", "[", "]", "{", "}" is deprecated since version 3.2 and will throw a ParseException in 4.0.', E_USER_DEPRECATED);`
`486`	`490`	`}`