minor #57732 [HttpFoundation] Add tests for MethodRequestMatcher and SchemeRequestMatcher (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit 6fe072949015 · 2024-07-26T14:36:27.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpFoundation] Add tests for `MethodRequestMatcher` and `SchemeRequestMatcher` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Following #57714 after rebasing on 5.4 Commits ------- 5a3c2a6 [HttpFoundation] Add tests for `MethodRequestMatcher` and `SchemeRequestMatcher`
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestMatcher/MethodRequestMatcherTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestMatcher/MethodRequestMatcherTest.php
@@ -27,6 +27,13 @@ public function test(string $requestMethod, array|string $matcherMethod, bool $i
         $this->assertSame($isMatch, $matcher->matches($request));
     }
 
+    public function testAlwaysMatchesOnEmptyMethod()
+    {
+        $matcher = new MethodRequestMatcher([]);
+        $request = Request::create('https://example.com', 'POST');
+        $this->assertTrue($matcher->matches($request));
+    }
+
     public static function getData()
     {
         return [
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestMatcher/SchemeRequestMatcherTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestMatcher/SchemeRequestMatcherTest.php
@@ -42,6 +42,13 @@ public function test(string $requestScheme, array|string $matcherScheme, bool $i
         }
     }
 
+    public function testAlwaysMatchesOnParamsHeaders()
+    {
+        $matcher = new SchemeRequestMatcher([]);
+        $request = Request::create('sftp://example.com');
+        $this->assertTrue($matcher->matches($request));
+    }
+
     public static function getData()
     {
         return [

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,13 @@ public function test(string $requestMethod, array\|string $matcherMethod, bool $i`
`27`	`27`	`$this->assertSame($isMatch, $matcher->matches($request));`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ public function testAlwaysMatchesOnEmptyMethod()`
	`31`	`+ {`
	`32`	`+ $matcher = new MethodRequestMatcher([]);`
	`33`	`+ $request = Request::create('https://example.com', 'POST');`
	`34`	`+ $this->assertTrue($matcher->matches($request));`
	`35`	`+ }`
	`36`	`+`
`30`	`37`	`public static function getData()`
`31`	`38`	`{`
`32`	`39`	`return [`
Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,13 @@ public function test(string $requestScheme, array\|string $matcherScheme, bool $i`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`
	`45`	`+ public function testAlwaysMatchesOnParamsHeaders()`
	`46`	`+ {`
	`47`	`+ $matcher = new SchemeRequestMatcher([]);`
	`48`	`+ $request = Request::create('sftp://example.com');`
	`49`	`+ $this->assertTrue($matcher->matches($request));`
	`50`	`+ }`
	`51`	`+`
`45`	`52`	`public static function getData()`
`46`	`53`	`{`
`47`	`54`	`return [`